From: Adrian Hunter <adrian.hunter@intel.com>
To: Sergey Yanovich <ynvich@gmail.com>
Cc: Chris Ball <cjb@laptop.org>, Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Namjae Jeon <linkinjeon@gmail.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] wait while adding MMC host to ensure root mounts
Date: Thu, 04 Apr 2013 14:35:04 +0300 [thread overview]
Message-ID: <515D6568.7000702@intel.com> (raw)
In-Reply-To: <1365073152.9806.26.camel@host5.omatika.ru>
On 04/04/13 13:59, Sergey Yanovich wrote:
> On Thu, 2013-04-04 at 09:35 +0300, Adrian Hunter wrote:
>> No, I am booting from eMMC.
>
> Well, in this case you should be aware, that your system is not
> concurrency-safe without the patch. It may or may not boot each time
> depending on the large number of factors.
Not true. You know nothing of my boot time characteristics.
>
>>> Maybe introduce mmc_is_hosting_root() and do something like:
>>>
>>> - mmc_flush_scheduled_work();
>>> + if (mmc_is_hosting_root())
>>> + mmc_flush_scheduled_work();
>>
>> No, I am booting from eMMC. Perhaps a host capability:
>>
>> if (host->caps2 & MMC_CAP2_ROOTWAIT)
>> mmc_flush_scheduled_work();
>>
>
> Neither my variant, nor yours will help to handle the increased boot
> time.
Not true. I would not set MMC_CAP2_ROOTWAIT.
> The root cause is that probing several devices is done sequentially and
> mmc was reporting end of its probing before it was actually happening.
Not true. The probe of the MMC Host Controller finishes when the host
controller is initialized.
> My patch makes mmc report end of probing on-time. The correct way to fix
> the additional delay, my patch introduces, is to rewrite the probing to
> be parallel instead of sequential. I understand that it is much easier
> just to revert the patch.
>
> If the patch is reverted, something like this somewhere in
> 'init/do_mounts.c' could conditionally activate 'root_wait':
>
> if (mmc_is_hosting_root())
> root_wait = 1;
>
> IMHO this is wrong and my patch is right, but better this than broken
> mmc boot.
No. Your patch is not right for my platform.
next prev parent reply other threads:[~2013-04-04 11:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 1:06 [PATCH] wait while adding MMC host to ensure root mounts Sergey Yanovich
2013-03-14 1:23 ` [PATCH v2] " Sergey Yanovich
2013-03-14 4:08 ` Namjae Jeon
2013-03-14 11:57 ` Sergey Yanovich
2013-03-15 2:51 ` Jaehoon Chung
2013-03-22 17:03 ` Chris Ball
2013-03-27 11:13 ` Ulf Hansson
2013-03-27 11:57 ` Chris Ball
2013-04-02 13:36 ` Adrian Hunter
2013-04-02 14:24 ` Sergey Yanovich
2013-04-04 6:35 ` Adrian Hunter
2013-04-04 10:59 ` Sergey Yanovich
2013-04-04 11:35 ` Adrian Hunter [this message]
2013-04-04 12:32 ` Sergey Yanovich
2013-04-13 10:49 ` Sergey Yanovich
2013-04-13 12:52 ` Chris Ball
[not found] ` <CAPDyKFrF8pmo7mfa_1Vi2n=JBFd1h+VULQ1hJB75=DmNx0erdw@mail.gmail.com>
2013-04-13 12:52 ` Sergey Yanovich
2013-03-27 12:28 ` Сергей Янович
2013-04-02 10:13 ` Ulf Hansson
2013-04-02 10:35 ` Sergey Yanovich
2013-04-02 17:45 ` Ulf Hansson
2013-04-02 18:56 ` Sergey Yanovich
2013-03-14 2:47 ` [PATCH] " Greg Kroah-Hartman
2013-03-14 10:28 ` Sergey Yanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D6568.7000702@intel.com \
--to=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jh80.chung@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).