* [PATCH] ALSA: pcm: constify attribute_group structures.
@ 2017-06-29 10:32 Arvind Yadav
2017-06-29 16:20 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-29 10:32 UTC (permalink / raw)
To: perex, tiwai; +Cc: alsa-devel, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/device.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
9781 240 8 10029 272d sound/core/pcm.o
File size After adding 'const':
text data bss dec hex filename
9813 176 8 9997 270d sound/core/pcm.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/core/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 8e980aa..ee3e8db0 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -1056,7 +1056,7 @@ static ssize_t show_pcm_class(struct device *dev,
NULL
};
-static struct attribute_group pcm_dev_attr_group = {
+static const struct attribute_group pcm_dev_attr_group = {
.attrs = pcm_dev_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: pcm: constify attribute_group structures.
2017-06-29 10:32 [PATCH] ALSA: pcm: constify attribute_group structures Arvind Yadav
@ 2017-06-29 16:20 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-06-29 16:20 UTC (permalink / raw)
To: Arvind Yadav; +Cc: perex, alsa-devel, linux-kernel
On Thu, 29 Jun 2017 12:32:56 +0200,
Arvind Yadav wrote:
>
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/device.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9781 240 8 10029 272d sound/core/pcm.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 9813 176 8 9997 270d sound/core/pcm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 10:32 [PATCH] ALSA: pcm: constify attribute_group structures Arvind Yadav
2017-06-29 16:20 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).