From: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com
Subject: Re: Re: [PATCH 2/2] trace-cmd: Support trace_clock extraction
Date: Thu, 11 Apr 2013 19:06:12 +0900 [thread overview]
Message-ID: <51668B14.9090800@hitachi.com> (raw)
In-Reply-To: <1365523237.25498.70.camel@gandalf.local.home>
Hi Steven,
Thank you for reviewing my patch set.
(2013/04/10 1:00), Steven Rostedt wrote:
> On Fri, 2013-04-05 at 10:54 +0900, Yoshihiro YUNOMAE wrote:
>> In this patch, trace-cmd reads trace_clock on debugfs in the report/extract
>> modes and outputs the data to trace.dat file. Then, in the report mode,
>> trace-cmd reads trace_clock data from the file and switches outputting format
>> of timestamp for each trace_clock.
>>
>> Note that by applying this patch, the binary format of trace.data is changed
>> as follows:
>>
>> <Current binary format>
>> ...
>> [size of saved_cmdlines]
>> [saved_cmdlines contents]
>> [total cpu number]
>> ...
>>
>> <Changed binary format>
>> ...
>> [size of saved_cmdlines]
>> [saved_cmdlines contents]
>> [size of trace_clock] <== add
>> [trace_clock contents] <== add
>> [total cpu number]
>> ...
>
> Hi Yoshihiro,
>
> I don't mind the feature addition, but I don't like the implementation.
> This will break backward compatibility with the trace.dat file, which
> I've been working hard not to have happen.
Yeah, I agree with you.
It is important that trace-cmd keeps backward compatibility.
> That doesn't mean that you can't implement this feature. This is what
> the options section is for. You can add an option that includes the
> trace_clock contents, or just simply say what type of clock is being
> used. Then a new trace-cmd can show the output like you want it to, and
> the old version will still work but show the old way, as trace-cmd is
> made to simply ignore options it does not know about.
Sounds good.
Maintenance of the implementation will be easier than that of my
implementation.
> I think it's time for me to push my latest updates to trace-cmd. As this
> will probably end up being the 3.0 version. I have examples there that
> use the options feature for more extensions that you can look at.
Thank you for pushing your latest patches!
I'll use your patches as a reference and submit the revised patches
using the options feature.
Thanks,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@hitachi.com
prev parent reply other threads:[~2013-04-11 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 1:54 [PATCH 0/2] trace-cmd: Support a raw format for outputting timestamp Yoshihiro YUNOMAE
2013-04-05 1:54 ` [PATCH 1/2] trace-cmd: Define general functions for outputting/inputting saved_cmdlines Yoshihiro YUNOMAE
2013-04-05 1:54 ` [PATCH 2/2] trace-cmd: Support trace_clock extraction Yoshihiro YUNOMAE
2013-04-09 16:00 ` Steven Rostedt
2013-04-09 16:07 ` Steven Rostedt
2013-04-11 10:06 ` Yoshihiro YUNOMAE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51668B14.9090800@hitachi.com \
--to=yoshihiro.yunomae.ez@hitachi.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).