From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965983Ab3DQJoJ (ORCPT ); Wed, 17 Apr 2013 05:44:09 -0400 Received: from intranet.asianux.com ([58.214.24.6]:42700 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965980Ab3DQJoH (ORCPT ); Wed, 17 Apr 2013 05:44:07 -0400 X-Spam-Score: -100.7 Message-ID: <516E6EBE.60706@asianux.com> Date: Wed, 17 Apr 2013 17:43:26 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: jason.wessel@windriver.com CC: kgdb-bugreport@lists.sourceforge.net, "linux-kernel@vger.kernel.org >> \"linux-kernel@vger.kernel.org\"" Subject: Re: [PATCH] kernel: debug: kdb: strncpy issue, using strlcpy instead of strncpy References: <51615692.2010906@asianux.com> In-Reply-To: <51615692.2010906@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello maintainers: please help check this patch, when you have time, thanks. On 2013年04月07日 19:20, Chen Gang wrote: > > kdb_prompt_str is NUL terminated string, need always set '\0' at the end. > > Signed-off-by: Chen Gang > --- > kernel/debug/kdb/kdb_io.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c > index 14ff484..932b436 100644 > --- a/kernel/debug/kdb/kdb_io.c > +++ b/kernel/debug/kdb/kdb_io.c > @@ -442,7 +442,7 @@ poll_again: > char *kdb_getstr(char *buffer, size_t bufsize, char *prompt) > { > if (prompt && kdb_prompt_str != prompt) > - strncpy(kdb_prompt_str, prompt, CMD_BUFLEN); > + strlcpy(kdb_prompt_str, prompt, CMD_BUFLEN); > kdb_printf(kdb_prompt_str); > kdb_nextline = 1; /* Prompt and input resets line number */ > return kdb_read(buffer, bufsize); > -- Chen Gang Asianux Corporation