From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95857FC6182 for ; Fri, 14 Sep 2018 17:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BE5D20853 for ; Fri, 14 Sep 2018 17:53:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE5D20853 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbeINXJV (ORCPT ); Fri, 14 Sep 2018 19:09:21 -0400 Received: from gloria.sntech.de ([185.11.138.130]:46152 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726891AbeINXJV (ORCPT ); Fri, 14 Sep 2018 19:09:21 -0400 Received: from p57b774c9.dip0.t-ipconnect.de ([87.183.116.201] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1g0sHV-0006oj-OQ; Fri, 14 Sep 2018 19:53:25 +0200 From: Heiko Stuebner To: Akash Gajjar Cc: deepak_das@mentor.com, Rob Herring , Mark Rutland , Jagan Teki , Levin Du , Ezequiel Garcia , Klaus Goger , Arnd Bergmann , Masahiro Yamada , Greg Kroah-Hartman , Shohei Maruyama , Shawn Lin , Heinrich Schuchardt , Enric Balletbo i Serra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: add initial dts support for Rockpro64 board Date: Fri, 14 Sep 2018 19:53:24 +0200 Message-ID: <5171978.eGO5IDoIUo@phil> In-Reply-To: <1536926957-12432-1-git-send-email-Akash_Gajjar@mentor.com> References: <1536926957-12432-1-git-send-email-Akash_Gajjar@mentor.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Akash, Am Freitag, 14. September 2018, 14:09:09 CEST schrieb Akash Gajjar: > Rockpro64 board is a rockchip RK3399 based board from pine64.org. > This commit adds initial device tree support for Rockpro64 board. > > Signed-off-by: Akash Gajjar generally the patch looks great already. Hopefully we will get an Ack from the dt-maintaintainers for the binding and I noticed two small issues I'll describe below. > --- > Documentation/devicetree/bindings/arm/rockchip.txt | 4 + > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 770 +++++++++++++++++++++ > 3 files changed, 775 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt > index acfd3c7..ac95183 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -160,6 +160,10 @@ Rockchip platforms device tree bindings > Required root node properties: > - compatible = "pine64,rock64", "rockchip,rk3328"; > > +- Pine64 RockPro64 board: > + Required root node properties: > + - compatible = "pine64,rockpro64", "rockchip,rk3399"; > + > - Rockchip PX3 Evaluation board: > Required root node properties: > - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188"; > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index b0092d9..03d523a 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -14,5 +14,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-bob.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-kevin.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > new file mode 100644 > index 0000000..9e2d4d9 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > @@ -0,0 +1,770 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd. Rockchip copyright from 2017? Where is the original dts coming from? > + */ > + > +/dts-v1/; > +#include > +#include > +#include "rk3399.dtsi" > +#include "rk3399-opp.dtsi" > + > +/ { > + model = "Pine64 RockPro64"; > + compatible = "pine64,rockpro64", "rockchip,rk3399"; > + > + chosen { > + stdout-path = "serial2:1500000n8"; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>; > + pwms = <&pwm0 0 25000 0>; > + brightness-levels = < > + 0 1 2 3 4 5 6 7 > + 8 9 10 11 12 13 14 15 > + 16 17 18 19 20 21 22 23 > + 24 25 26 27 28 29 30 31 > + 32 33 34 35 36 37 38 39 > + 40 41 42 43 44 45 46 47 > + 48 49 50 51 52 53 54 55 > + 56 57 58 59 60 61 62 63 > + 64 65 66 67 68 69 70 71 > + 72 73 74 75 76 77 78 79 > + 80 81 82 83 84 85 86 87 > + 88 89 90 91 92 93 94 95 > + 96 97 98 99 100 101 102 103 > + 104 105 106 107 108 109 110 111 > + 112 113 114 115 116 117 118 119 > + 120 121 122 123 124 125 126 127 > + 128 129 130 131 132 133 134 135 > + 136 137 138 139 140 141 142 143 > + 144 145 146 147 148 149 150 151 > + 152 153 154 155 156 157 158 159 > + 160 161 162 163 164 165 166 167 > + 168 169 170 171 172 173 174 175 > + 176 177 178 179 180 181 182 183 > + 184 185 186 187 188 189 190 191 > + 192 193 194 195 196 197 198 199 > + 200 201 202 203 204 205 206 207 > + 208 209 210 211 212 213 214 215 > + 216 217 218 219 220 221 222 223 > + 224 225 226 227 228 229 230 231 > + 232 233 234 235 236 237 238 239 > + 240 241 242 243 244 245 246 247 > + 248 249 250 251 252 253 254 255>; > + default-brightness-level = <200>; with recent additions to the pwm-backlight we shouldn't need the long brightness-levels table and default-brightness-level anymore. Heiko