From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755115AbcBZUcw (ORCPT ); Fri, 26 Feb 2016 15:32:52 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:52354 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754706AbcBZUcu (ORCPT ); Fri, 26 Feb 2016 15:32:50 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Florian Fainelli , sbranden@broadcom.com, rjui@broadcom.com, linux-kernel@vger.kernel.org, Justin Chen , bcm-kernel-feedback-list@broadcom.com, Justin Chen , gregory.0xf0@gmail.com, computersforpeace@gmail.com Subject: Re: [PATCH] bsp: add SoC device to brcmstb Date: Fri, 26 Feb 2016 21:32:21 +0100 Message-ID: <5174855.MZxnsKaRHh@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56D09B2B.8090805@gmail.com> References: <1456445947-9079-1-git-send-email-justinpopo6@gmail.com> <4679582.DyKPu0pJrQ@wuerfel> <56D09B2B.8090805@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:XmE9mOTDJcpt4gKVTPy97GYn92DEhylWcsg/wWoLG3cTy0DnChK B7BSuu3K83gEyf74beriv1CvnG4OsxS9TvGDUIl3qltr1JMhZEBpy+apy8PjYV6ca9UGvmp y1+eDyz2kyPfgt6xJdlrt0HhJy9GS28CTm729Skeo0jkPm/iHmREb7v5nrBOSu8OmyQOplR ZAkZm5oaWMzMm0FIR9M9w== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vpf5wEi/5Mc=:7r05Ji2j294HX0+MNcwEQr 8WoT0Mgo12VcGfcD20cXCDj4vY3RT+T+8w5K2+K4WLPuco/xm7KzDJ975/XoMFtfQ2E4FdYIr 96/rW5+HxfpQpl7Sz8d6DCIONiuart4JvT2Sutdm9nt+myzSmt8GKJLMyVvPisfAEyAHp/uiO 8oes0on9SfLuAZz3UCzD2AGxrbEUg+p9BkYcRz9+UF4v0VtYvnDofnFNm/1p2LFjoLTDZnRbS mc0TgFtY0aLu2idZO1WnlW8TEj7x1bVm9ZVTIUchUNHFHKA8RhFIoDUqXS8hrsi3CMitHdx1j nv73Dh0uPMDQoAuVxv1/u6Toy6ZtdW1d67Vtbf9wjrUOvRaNAqiT+ca0Cu0XsNsQ+ABM1MGIQ onxU5/q8d1UX69R3zb8SMrarGWfR3Jl0su57Y15I+wtQm0p+kAULl9hsKUGXgOY1H6yRStNiI 4AbtlqZHKllgyq5cQBiXVgm/oeg7smC8k6sL4WIDwgtx6x1mY685AXGaWU0QW1jqwLDr4VHEa tvGlk4EAwid+dCU0d2nqoCUgKN38G3KBW12NU3UbaJ8Aa4I8xma7n5yJnsb1iisLDsjomCwP9 p0Pptv6qcxMqF6SbAdwDbS+j62tKEnBHB72389YmSsgrmjQDkdihChOD6VOcmTvuslFUJp9oN /De20zaqLGQ9AMD6T9nAzbCMeO+3f/zjActND7AD1tTp1sRN0mq42jynrXGkNAWq3CmoYVw13 3t1iT/8YWfe5hJMQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 26 February 2016 10:36:27 Florian Fainelli wrote: > On 26/02/16 05:58, Arnd Bergmann wrote: > > On Thursday 25 February 2016 16:19:07 Justin Chen wrote: > >> */ > >> void brcmstb_biuctrl_init(void); > >> > >> +/* > >> + * Helper functions for getting family or product id from the > >> + * SoC driver. > >> + */ > >> +u32 brcmstb_get_family_id(void); > >> +u32 brcmstb_get_product_id(void); > >> + > >> #endif /* __BRCMSTB_SOC_H */ > >> -- > > > > Please remove the declarations from the header file and make the > > variable local to this file, to make sure no other driver accidentally > > accesses them. > > I would remove these two helper functions completely, we do not need > them right now in an upstream kernel, if we ever need them, we could add > them back, but we have no use for these two now. Ok, that sounds even better. Arnd