From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1465C433E6 for ; Thu, 11 Feb 2021 10:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8397D64E8B for ; Thu, 11 Feb 2021 10:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbhBKK1g (ORCPT ); Thu, 11 Feb 2021 05:27:36 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10430 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhBKKVy (ORCPT ); Thu, 11 Feb 2021 05:21:54 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 11 Feb 2021 02:21:08 -0800 Received: from [10.26.49.8] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 11 Feb 2021 10:21:05 +0000 Subject: Re: phy_attach_direct()'s use of device_bind_driver() To: Andrew Lunn , Saravana Kannan CC: Heiner Kallweit , Russell King , "David S. Miller" , "Jakub Kicinski" , Android Kernel Team , netdev , LKML , "Thierry Reding" References: From: Jon Hunter Message-ID: <5176f496-facb-d7b0-9f4e-a9e4b8974178@nvidia.com> Date: Thu, 11 Feb 2021 10:21:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1613038868; bh=SljrkEVHDmi6xA8MKmgtTpSTzDd2Vz3b1ust/JTNqig=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=MMLGArFdzoF7FHQjCanG/GBKSJ8WlQ7YLkM32dEFhchpZoW9/o101ST5rm75hv+L9 kpnX0wl0z1rcR24xBTLWbP1IPfRFZ3NPSn5uWW3SU4q6T8stbnSXoSFS3U7sBKkgwp 3XER6VJFs/QntXgvrayXvvhvWfjnxMObN3mzLj6Z973RkR2QfFkBdAGmDRtYLYZqRy 43zKexpg8HdHEz7aqtaltdd8KVmkg/1yPetg/56/sRGDSVKe3UnlagVLVYRfBAY0gs d2hVqjzoP/Cj7H2soWLdM3Gk3Wd1XocsYQd/llYk+hn8d6Igk5NkU4tXV9QHsqDI9i 8Q8OxTYNZ+giw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2021 22:56, Andrew Lunn wrote: > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote: >> Hi, >> >> This email was triggered by this other email[1]. > > And it appears the Tegra194 Jetson Xavier uses the Marvell 88E1512 > PHY. So ensure the Marvell driver is available, and it should get > probed in the usual way, the fallback driver will not be needed. Yes that is correct. Enabling the Marvell PHY does fix this indeed and so I can enable that as part of our testsuite. We were seeing the same warning on Tegra186 Jetson TX2 and enabling the BRCM PHY resolves that as well. I will ensure that these are enabled going forward. Cheers Jon -- nvpublic