From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751493AbcFRNrT (ORCPT ); Sat, 18 Jun 2016 09:47:19 -0400 Received: from gloria.sntech.de ([95.129.55.99]:59330 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbcFRNrS (ORCPT ); Sat, 18 Jun 2016 09:47:18 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3] clocksource/drivers/rockchip_timer: Convert init function to return error Date: Sat, 18 Jun 2016 15:47:13 +0200 Message-ID: <5185607.7BCdEvMvLD@diego> User-Agent: KMail/4.14.10 (Linux/4.5.0-2-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1466254447-2420-1-git-send-email-daniel.lezcano@linaro.org> References: <2572341.0UcvQ6PvRt@diego> <1466254447-2420-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, 18. Juni 2016, 14:54:07 schrieb Daniel Lezcano: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano looks good now :-) Reviewed-by: Heiko Stuebner on a rk3399-evb Tested-by: Heiko Stuebner Heiko