From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35177C2BB1D for ; Wed, 11 Mar 2020 18:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2259206BE for ; Wed, 11 Mar 2020 18:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730869AbgCKSp7 (ORCPT ); Wed, 11 Mar 2020 14:45:59 -0400 Received: from mga04.intel.com ([192.55.52.120]:45178 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730691AbgCKSp6 (ORCPT ); Wed, 11 Mar 2020 14:45:58 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 11:45:58 -0700 X-IronPort-AV: E=Sophos;i="5.70,541,1574150400"; d="scan'208";a="277479353" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.251.23.31]) ([10.251.23.31]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Mar 2020 11:45:57 -0700 Subject: Re: [PATCH V1 01/13] selftests/resctrl: Fix feature detection To: Sai Praneeth Prakhya , "shuah@kernel.org" , "linux-kselftest@vger.kernel.org" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "Luck, Tony" , "babu.moger@amd.com" , "james.morse@arm.com" , "Shankar, Ravi V" , "Yu, Fenghua" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" References: <7e3e4b91f5786a489e68eecda21e1d8049b60181.1583657204.git.sai.praneeth.prakhya@intel.com> <664cf142449b0a1ef7f09d04111f96ff84738e28.camel@intel.com> From: Reinette Chatre Message-ID: <518831ab-0f4e-5c5c-10c2-52c5f8492df1@intel.com> Date: Wed, 11 Mar 2020 11:45:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <664cf142449b0a1ef7f09d04111f96ff84738e28.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sai, On 3/11/2020 11:22 AM, Sai Praneeth Prakhya wrote: > Hi Reinette, > > On Wed, 2020-03-11 at 11:06 -0700, Reinette Chatre wrote: >> Hi Sai, >> >> On 3/9/2020 3:51 PM, Prakhya, Sai Praneeth wrote: >>>> -----Original Message----- >>>> From: Reinette Chatre >>>> Sent: Monday, March 9, 2020 3:34 PM >>> >>> [SNIP] >>> >>>>> That's a good point and makes sense to me. I think we could fix it in >>>>> two ways 1. grep for strings in dmesg but that will still leave >>>>> ambiguity in deciding b/w mbm and cqm because kernel prints "resctrl: >>>>> L3 >>>> monitoring detected" for both the features 2. Check in "info" directory >>>>> a. For cat_l3, we could search for info/L3 >>>>> b. For mba, we could search for info/MB >>>>> c. For cqm and mbm, we could search for specified string in >>>>> info/L3_MON/mon_features >>>>> >>>>> I think option 2 might be better because it can handle all cases, >>>>> please let me >>>> know what you think. >>>> >>>> I agree. For the reasons you mention and also that (1) may not be >>>> possible if the >>>> loglevel prevents those lines from being printed. >>> >>> Makes sense. I will work on the fix. >> >> One more note about this ... from what I can tell the test for a feature >> currently fails if the platform does not support the feature. Would it >> be possible to just skip the test in this case instead? > > That's because the output of the test should be just "ok" or "not ok". The output could be something like: ok MBA # SKIP MBA is not supported > I can change it to something like "# Skip because platform doesn't > support the feature", but not really sure if it complies with TAP 13 protocol. Please consider the "skip" directive at https://testanything.org/tap-version-13-specification.html Reinette