From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>, Joerg Roedel <joro@8bytes.org>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
kvm@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul
Date: Wed, 8 Dec 2021 15:51:28 +0100 [thread overview]
Message-ID: <518c3e07-41c8-feeb-5298-702c101994c7@redhat.com> (raw)
In-Reply-To: <20211208015236.1616697-1-seanjc@google.com>
On 12/8/21 02:52, Sean Christopherson wrote:
> Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX,
> AVIC on AMD SVM) to streamline things as much as possible, remove a bunch
> of cruft, and document the lurking gotchas along the way.
>
> Patch 01 is a fix from Paolo that's already been merged but hasn't made
> its way to kvm/queue. It's included here to avoid a number of conflicts.
>
> Based on kvm/queue, commit 1cf84614b04a ("KVM: x86: Exit to ...")
Queued, thanks; patches 24-26 for 5.16 and the rest for 5.17.
Just one nit: please tune the language to have a little fewer idiomatic
phrases, as that can be a bit taxing on non-native speakers. I for one
enjoy learning a few new words, and it even adds some "personality" to
the remote interactions, but it probably distracts people that aren't
too preficient in English.
Paolo
> v3:
> - Rebase to kvm/queue (and drop non-x86 patches as they've been queued).
> - Redo AVIC patches, sadly the vcpu_(un)blocking() hooks need to stay.
> - Add a patch to fix a missing (docuentation-only) barrier in nested
> posted interrupt delivery. [Paolo]
> - Collect reviews.
>
> v2:
> - https://lore.kernel.org/all/20211009021236.4122790-1-seanjc@google.com/
> - Collect reviews. [Christian, David]
> - Add patch to move arm64 WFI functionality out of hooks. [Marc]
> - Add RISC-V to the fun.
> - Add all the APICv fun.
>
> v1: https://lkml.kernel.org/r/20210925005528.1145584-1-seanjc@google.com
>
> Paolo Bonzini (1):
> KVM: fix avic_set_running for preemptable kernels
>
> Sean Christopherson (25):
> KVM: nVMX: Ensure vCPU honors event request if posting nested IRQ
> fails
> KVM: VMX: Clean up PI pre/post-block WARNs
> KVM: VMX: Handle PI wakeup shenanigans during vcpu_put/load
> KVM: Drop unused kvm_vcpu.pre_pcpu field
> KVM: Move x86 VMX's posted interrupt list_head to vcpu_vmx
> KVM: VMX: Move preemption timer <=> hrtimer dance to common x86
> KVM: x86: Unexport LAPIC's switch_to_{hv,sw}_timer() helpers
> KVM: x86: Remove defunct pre_block/post_block kvm_x86_ops hooks
> KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode
> KVM: SVM: Don't bother checking for "running" AVIC when kicking for
> IPIs
> KVM: SVM: Remove unnecessary APICv/AVIC update in vCPU unblocking path
> KVM: SVM: Use kvm_vcpu_is_blocking() in AVIC load to handle preemption
> KVM: SVM: Skip AVIC and IRTE updates when loading blocking vCPU
> iommu/amd: KVM: SVM: Use pCPU to infer IsRun state for IRTE
> KVM: VMX: Don't do full kick when triggering posted interrupt "fails"
> KVM: VMX: Wake vCPU when delivering posted IRQ even if vCPU == this
> vCPU
> KVM: VMX: Pass desired vector instead of bool for triggering posted
> IRQ
> KVM: VMX: Fold fallback path into triggering posted IRQ helper
> KVM: VMX: Don't do full kick when handling posted interrupt wakeup
> KVM: SVM: Drop AVIC's intermediate avic_set_running() helper
> KVM: SVM: Move svm_hardware_setup() and its helpers below svm_x86_ops
> KVM: SVM: Nullify vcpu_(un)blocking() hooks if AVIC is disabled
> KVM: x86: Skip APICv update if APICv is disable at the module level
> KVM: x86: Drop NULL check on kvm_x86_ops.check_apicv_inhibit_reasons
> KVM: x86: Unexport __kvm_request_apicv_update()
>
> arch/x86/include/asm/kvm-x86-ops.h | 2 -
> arch/x86/include/asm/kvm_host.h | 12 -
> arch/x86/kvm/hyperv.c | 3 +
> arch/x86/kvm/lapic.c | 2 -
> arch/x86/kvm/svm/avic.c | 116 ++++---
> arch/x86/kvm/svm/svm.c | 479 ++++++++++++++---------------
> arch/x86/kvm/svm/svm.h | 16 +-
> arch/x86/kvm/vmx/posted_intr.c | 234 +++++++-------
> arch/x86/kvm/vmx/posted_intr.h | 8 +-
> arch/x86/kvm/vmx/vmx.c | 66 ++--
> arch/x86/kvm/vmx/vmx.h | 3 +
> arch/x86/kvm/x86.c | 41 ++-
> drivers/iommu/amd/iommu.c | 6 +-
> include/linux/amd-iommu.h | 6 +-
> include/linux/kvm_host.h | 3 -
> virt/kvm/kvm_main.c | 3 -
> 16 files changed, 510 insertions(+), 490 deletions(-)
>
next prev parent reply other threads:[~2021-12-08 14:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:52 [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 01/26] KVM: fix avic_set_running for preemptable kernels Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 02/26] KVM: nVMX: Ensure vCPU honors event request if posting nested IRQ fails Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 03/26] KVM: VMX: Clean up PI pre/post-block WARNs Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 04/26] KVM: VMX: Handle PI wakeup shenanigans during vcpu_put/load Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 05/26] KVM: Drop unused kvm_vcpu.pre_pcpu field Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 06/26] KVM: Move x86 VMX's posted interrupt list_head to vcpu_vmx Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 07/26] KVM: VMX: Move preemption timer <=> hrtimer dance to common x86 Sean Christopherson
2023-03-29 12:34 ` Tudor Ambarus
2023-03-29 13:47 ` Paolo Bonzini
2023-03-29 15:22 ` Tudor Ambarus
2023-03-30 7:12 ` Tudor Ambarus
2021-12-08 1:52 ` [PATCH v3 08/26] KVM: x86: Unexport LAPIC's switch_to_{hv,sw}_timer() helpers Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 09/26] KVM: x86: Remove defunct pre_block/post_block kvm_x86_ops hooks Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 10/26] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 11/26] KVM: SVM: Don't bother checking for "running" AVIC when kicking for IPIs Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 12/26] KVM: SVM: Remove unnecessary APICv/AVIC update in vCPU unblocking path Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 13/26] KVM: SVM: Use kvm_vcpu_is_blocking() in AVIC load to handle preemption Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 14/26] KVM: SVM: Skip AVIC and IRTE updates when loading blocking vCPU Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 15/26] iommu/amd: KVM: SVM: Use pCPU to infer IsRun state for IRTE Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 16/26] KVM: VMX: Don't do full kick when triggering posted interrupt "fails" Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 17/26] KVM: VMX: Wake vCPU when delivering posted IRQ even if vCPU == this vCPU Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 18/26] KVM: VMX: Pass desired vector instead of bool for triggering posted IRQ Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 19/26] KVM: VMX: Fold fallback path into triggering posted IRQ helper Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 20/26] KVM: VMX: Don't do full kick when handling posted interrupt wakeup Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 21/26] KVM: SVM: Drop AVIC's intermediate avic_set_running() helper Sean Christopherson
2021-12-08 14:43 ` Paolo Bonzini
2021-12-08 15:03 ` Maxim Levitsky
2021-12-08 15:43 ` Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 22/26] KVM: SVM: Move svm_hardware_setup() and its helpers below svm_x86_ops Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 23/26] KVM: SVM: Nullify vcpu_(un)blocking() hooks if AVIC is disabled Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 24/26] KVM: x86: Skip APICv update if APICv is disable at the module level Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 25/26] KVM: x86: Drop NULL check on kvm_x86_ops.check_apicv_inhibit_reasons Sean Christopherson
2021-12-08 1:52 ` [PATCH v3 26/26] KVM: x86: Unexport __kvm_request_apicv_update() Sean Christopherson
2021-12-08 9:04 ` [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul Paolo Bonzini
2021-12-08 14:51 ` Paolo Bonzini [this message]
2021-12-08 23:00 ` Maxim Levitsky
2021-12-08 23:16 ` Maxim Levitsky
2021-12-08 23:34 ` Maxim Levitsky
2021-12-09 0:04 ` Sean Christopherson
2021-12-09 6:36 ` Maxim Levitsky
2021-12-09 0:02 ` Sean Christopherson
2021-12-09 14:29 ` Paolo Bonzini
2021-12-09 14:48 ` Maxim Levitsky
2021-12-09 15:45 ` Sean Christopherson
2021-12-09 16:03 ` Maxim Levitsky
2021-12-09 1:37 ` Sean Christopherson
2021-12-09 6:31 ` Maxim Levitsky
2021-12-08 23:43 ` Sean Christopherson
2021-12-09 6:34 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518c3e07-41c8-feeb-5298-702c101994c7@redhat.com \
--to=pbonzini@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).