From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762900AbdEVXYc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 19:24:32 -0400
Received: from mail-it0-f66.google.com ([209.85.214.66]:32952 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752443AbdEVXY2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 19:24:28 -0400
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs
 PAGE_SIZE in tlb flush code
From: Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <29e74164b213b349fd9c4bc1bec5e154af38ac87.1495492063.git.luto@kernel.org>
Date: Mon, 22 May 2017 16:24:23 -0700
Cc: X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bpetkov@suse.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Rik van Riel <riel@redhat.com>, Dave Hansen <dave.hansen@intel.com>,
        Nadav Amit <namit@vmware.com>, Michal Hocko <mhocko@suse.com>,
        Arjan van de Ven <arjan@linux.intel.com>
Message-Id: <519997CE-E94C-40E3-96A7-48CA682B553E@gmail.com>
References: <cover.1495492063.git.luto@kernel.org>
 <cover.1495492063.git.luto@kernel.org>
 <29e74164b213b349fd9c4bc1bec5e154af38ac87.1495492063.git.luto@kernel.org>
To: Andy Lutomirski <luto@kernel.org>
X-Mailer: Apple Mail (2.3273)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4MNOYum032487

> 
> 	/* Balance as user space task's flush, a bit conservative */
> 	if (end == TLB_FLUSH_ALL ||
> -	    (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
> +	    (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {

Shouldn’t it be << ?

Nadav