From: "Jan Beulich" <JBeulich@suse.com>
To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: "David Vrabel" <david.vrabel@citrix.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Chien Yen" <chien.yen@oracle.com>,
"Feng Jin" <joe.jin@oracle.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Zhenzhong Duan" <zhenzhong.duan@oracle.com>,
"Ingo Molnar" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH] xen: reuse the same pirq allocated when driver load first time
Date: Wed, 22 May 2013 10:37:39 +0100 [thread overview]
Message-ID: <519CAE0302000078000D807A@nat28.tlf.novell.com> (raw)
In-Reply-To: <20130521224125.GA3483@phenom.dumpdata.com>
>>> On 22.05.13 at 00:41, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Tue, May 21, 2013 at 10:50:09PM +0100, Stefano Stabellini wrote:
>> We have to be careful about this: the point of PHYSDEVOP_get_free_pirq is
>> that Linux can know for sure the pirq that is going to be used to map the
>> MSI by QEMU. If you modify is_free_pirq that way, suddenly the pirq
>> could be allocated for something else after Linux called
>> PHYSDEVOP_get_free_pirq and before QEMU called xc_physdev_map_pirq_msi.
>
> Yes. And I think the 'is_free_pirq' modification above is incorrect.
>
> I think the fix should be in the unmap_pirq code (hypervisor) to check
> if the arch.irq is either zero or PIRQ_ALLOCATED. Right now it only
> checks for zero.
Which check are you talking about? Looking at physdev_unmap_pirq()
I see none at all, unmap_domain_pirq() has a <= 0 check, and
unmap_domain_pirq_emuirq() again doesn't appear to have any.
If you're talking about unmap_domain_pirq(), then you'll need to
be careful: A negative value here doesn't necessarily mean
PIRQ_ALLOCATED, but could also come from another run that
found it necessary to force the unbind. Hence the definition of
PIRQ_ALLOCATED would then collide with the (unlikely?) case of
IRQ1 having got assigned to a guest. To be on the safe side, we
should therefore redefine PIRQ_ALLOCATED to say INT_MIN.
Jan
next prev parent reply other threads:[~2013-05-22 9:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 8:18 [PATCH] xen: reuse the same pirq allocated when driver load first time Zhenzhong Duan
2013-05-10 18:53 ` Konrad Rzeszutek Wilk
2013-05-13 7:44 ` Zhenzhong Duan
2013-05-13 11:06 ` Stefano Stabellini
2013-05-13 14:07 ` Konrad Rzeszutek Wilk
2013-05-13 14:50 ` Stefano Stabellini
2013-05-13 16:17 ` Konrad Rzeszutek Wilk
2013-05-13 17:24 ` Stefano Stabellini
2013-05-13 18:20 ` Konrad Rzeszutek Wilk
2013-05-14 13:49 ` Stefano Stabellini
2013-05-14 14:20 ` Konrad Rzeszutek Wilk
2013-05-15 9:41 ` Stefano Stabellini
2013-05-15 14:18 ` Zhenzhong Duan
2013-05-17 2:22 ` Zhenzhong Duan
2013-05-20 10:24 ` Stefano Stabellini
2013-05-20 15:24 ` Konrad Rzeszutek Wilk
2013-05-20 17:57 ` Konrad Rzeszutek Wilk
2013-05-20 20:38 ` Konrad Rzeszutek Wilk
2013-05-21 10:07 ` [Xen-devel] " David Vrabel
2013-05-21 13:40 ` Konrad Rzeszutek Wilk
2013-05-21 16:51 ` Stefano Stabellini
2013-05-21 20:42 ` Konrad Rzeszutek Wilk
2013-05-21 21:50 ` Stefano Stabellini
2013-05-21 22:41 ` Konrad Rzeszutek Wilk
2013-05-22 9:37 ` Jan Beulich [this message]
2013-05-22 15:14 ` Konrad Rzeszutek Wilk
2013-05-22 15:25 ` Jan Beulich
2013-05-22 16:41 ` Konrad Rzeszutek Wilk
2013-05-23 6:31 ` Jan Beulich
2013-05-29 17:50 ` Stefano Stabellini
2013-05-30 17:48 ` Konrad Rzeszutek Wilk
[not found] ` <51AECC3A.7060803@oracle.com>
2013-06-05 12:50 ` Stefano Stabellini
2013-06-20 2:57 ` Zhenzhong Duan
2013-06-20 14:21 ` Stefano Stabellini
2013-06-24 7:19 ` Zhenzhong Duan
2013-06-24 17:18 ` Stefano Stabellini
2013-06-25 5:33 ` DuanZhenzhong
2013-06-25 17:51 ` Stefano Stabellini
2013-06-26 4:00 ` Zhenzhong Duan
2013-06-26 18:08 ` Stefano Stabellini
2013-06-27 4:01 ` Zhenzhong Duan
2013-06-27 11:52 ` Stefano Stabellini
2013-06-28 2:33 ` Zhenzhong Duan
2013-06-28 11:12 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519CAE0302000078000D807A@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=chien.yen@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=joe.jin@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
--cc=yuval.shaia@oracle.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).