linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
	hannes@cmpxchg.org, riel@redhat.com, mhocko@suse.cz,
	linux-mm@kvack.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/vmscan.c: 'lru' may be used without initialized after the patch "3abf380..." in next-20130607 tree
Date: Wed, 19 Jun 2013 15:19:23 +0800	[thread overview]
Message-ID: <51C15B7B.9060804@asianux.com> (raw)
In-Reply-To: <20130619001029.ee623fae.akpm@linux-foundation.org>

On 06/19/2013 03:10 PM, Andrew Morton wrote:
> On Wed, 19 Jun 2013 14:55:13 +0800 Chen Gang <gang.chen@asianux.com> wrote:
> 
>> > 
>> > 'lru' may be used without initialized, so need regressing part of the
>> > related patch.
>> > 
>> > The related patch:
>> >   "3abf380 mm: remove lru parameter from __lru_cache_add and lru_cache_add_lru"
>> >
>> > ...
>> >
>> > --- a/mm/vmscan.c
>> > +++ b/mm/vmscan.c
>> > @@ -595,6 +595,7 @@ redo:
>> >  		 * unevictable page on [in]active list.
>> >  		 * We know how to handle that.
>> >  		 */
>> > +		lru = !!TestClearPageActive(page) + page_lru_base_type(page);
>> >  		lru_cache_add(page);
>> >  	} else {
>> >  		/*
> That looks right.  Why the heck didn't gcc-4.4.4 (at least) warn about it?
> 

Sorry I don't know either, I find it by reading code, this time.

It is really necessary to continue analyzing why. In 2nd half of 2013, I
have planned to make some patches outside kernel but related with kernel
(e.g. LTP, gcc patches).

This kind of issue is a good chance for me to start in 2nd half of 2013
(start from next month).

So if no others reply for it, I will start analyzing it in the next
month, and plan to finish within a month (before 2013-07-31).


Welcome additional suggestions or completions.

Thanks.
-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-06-19  7:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  6:55 [PATCH] mm/vmscan.c: 'lru' may be used without initialized after the patch "3abf380..." in next-20130607 tree Chen Gang
2013-06-19  7:10 ` Andrew Morton
2013-06-19  7:19   ` Chen Gang [this message]
2013-07-05  4:06     ` Chen Gang
2013-07-08  6:43       ` Chen Gang
2013-07-09  2:16         ` Chen Gang
2013-06-19  8:53 ` Mel Gorman
2013-06-19  9:56   ` Chen Gang
2013-06-19 10:25     ` [PATCH v2] " Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C15B7B.9060804@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).