From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <djbw@fb.com>
Cc: Jon Mason <jon.mason@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag
Date: Wed, 19 Jun 2013 10:36:50 -0700 [thread overview]
Message-ID: <51C1EC32.6020204@intel.com> (raw)
In-Reply-To: <CAA9_cmeie_V0PauHBadVsg22OQmFrC_Oeg1o1FwdzQ+mVU9gTA@mail.gmail.com>
On 06/18/2013 05:59 PM, Dan Williams wrote:
> On Tue, Jun 18, 2013 at 5:46 PM, Jon Mason <jon.mason@intel.com> wrote:
>> Set the DMA_PRIVATE dma_transaction_type in the capability mask. This
>> enables the ability to get an exclusive ioatdma DMA channel for any
>> devices that requests one via the dma_request_channel function call.
>>
>> Signed-off-by: Jon Mason <jon.mason@intel.com>
>> Acked-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>> drivers/dma/ioat/dma_v3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
>> index ca6ea9b..ac2aeef 100644
>> --- a/drivers/dma/ioat/dma_v3.c
>> +++ b/drivers/dma/ioat/dma_v3.c
>> @@ -1883,6 +1883,7 @@ int ioat3_dma_probe(struct ioatdma_device *device, int dca)
>> dma->copy_align = 6;
>>
>> dma_cap_set(DMA_INTERRUPT, dma->cap_mask);
>> + dma_cap_set(DMA_PRIVATE, dma->cap_mask);
>> dma->device_prep_dma_interrupt = ioat3_prep_interrupt_lock;
> DMA_PRIVATE here keeps all channels private, so they couldn't be used
> elsewhere, for example raid offload. Do you need a private allocation
> or can you get away with a dynamically assigned channel?
So is there no way to reserve a channel as private if no one is using
it? It seems the current setup is async_tx or nothing.
--
Dave Jiang
Application Engineer, Storage Divsion
Intel Corp.
dave.jiang@intel.com
next prev parent reply other threads:[~2013-06-19 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 0:46 [PATCH 0/2] DMA Offload fixes Jon Mason
2013-06-19 0:46 ` [PATCH 1/2] dmadevices: dma_sync_wait undefined Jon Mason
2013-06-19 1:13 ` Dan Williams
2013-06-19 16:28 ` Jon Mason
2013-06-20 21:20 ` Dan Williams
2013-06-26 23:47 ` Jon Mason
2013-06-19 0:46 ` [PATCH 2/2] ioatdma: add DMA_PRIVATE capabilities flag Jon Mason
2013-06-19 0:59 ` Dan Williams
2013-06-19 17:36 ` Dave Jiang [this message]
2013-06-19 17:52 ` Jon Mason
2013-06-19 18:56 ` Dan Williams
2013-06-19 20:10 ` Jon Mason
2013-06-19 20:44 ` Dan Williams
2013-06-26 23:55 ` Jon Mason
2013-06-27 1:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C1EC32.6020204@intel.com \
--to=dave.jiang@intel.com \
--cc=djbw@fb.com \
--cc=jon.mason@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).