From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757830Ab3FTMmg (ORCPT ); Thu, 20 Jun 2013 08:42:36 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37123 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757711Ab3FTMmf (ORCPT ); Thu, 20 Jun 2013 08:42:35 -0400 Message-ID: <51C2F8A0.4040009@ti.com> Date: Thu, 20 Jun 2013 15:42:08 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , , , , Subject: Re: [RFC PATCH 6/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host References: <1371650753-11452-1-git-send-email-rogerq@ti.com> <1371650753-11452-7-git-send-email-rogerq@ti.com> <51C1EA99.2020401@cogentembedded.com> In-Reply-To: <51C1EA99.2020401@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/19/2013 08:30 PM, Sergei Shtylyov wrote: > Hello. > > On 06/19/2013 06:05 PM, Roger Quadros wrote: > >> To ensure hardware context is restored while resuming from >> OFF mode we need to enable the Hardware SAR bit for the >> USB Host power domain. > >> Signed-off-by: Roger Quadros >> --- >> arch/arm/mach-omap2/powerdomains3xxx_data.c | 8 +------- >> 1 files changed, 1 insertions(+), 7 deletions(-) > >> diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c b/arch/arm/mach-omap2/powerdomains3xxx_data.c >> index f0e14e9..9554d2b 100644 >> --- a/arch/arm/mach-omap2/powerdomains3xxx_data.c >> +++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c >> @@ -289,13 +289,7 @@ static struct powerdomain usbhost_pwrdm = { >> .prcm_offs = OMAP3430ES2_USBHOST_MOD, >> .pwrsts = PWRSTS_OFF_RET_ON, >> .pwrsts_logic_ret = PWRSTS_RET, >> - /* >> - * REVISIT: Enabling usb host save and restore mechanism seems to >> - * leave the usb host domain permanently in ACTIVE mode after >> - * changing the usb host power domain state from OFF to active once. >> - * Disabling for now. >> - */ >> - /*.flags = PWRDM_HAS_HDWR_SAR,*/ /* for USBHOST ctrlr only */ >> + .flags = PWRDM_HAS_HDWR_SAR, /* for USBHOST ctrlr only */ > > Looks like you're not indenting = right, in accordance to the other fields... Will fix. Thanks. cheers, -roger