From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423014Ab3FUBJw (ORCPT ); Thu, 20 Jun 2013 21:09:52 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:24330 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1423001Ab3FUBJv (ORCPT ); Thu, 20 Jun 2013 21:09:51 -0400 X-IronPort-AV: E=Sophos;i="4.87,908,1363104000"; d="scan'208";a="7621292" Message-ID: <51C3A88D.30408@cn.fujitsu.com> Date: Fri, 21 Jun 2013 09:12:45 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Zhang Yanfei CC: bcrl@kvack.org, akpm@linux-foundation.org, hpa@zytor.com, trivial@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] page_isolation: Fix a comment typo in test_pages_isolated() References: <1371723023-4060-1-git-send-email-tangchen@cn.fujitsu.com> <1371723023-4060-2-git-send-email-tangchen@cn.fujitsu.com> <51C300FF.50208@gmail.com> In-Reply-To: <51C300FF.50208@gmail.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/21 09:08:36, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/21 09:08:41, Serialize complete at 2013/06/21 09:08:41 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2013 09:17 PM, Zhang Yanfei wrote: > On 06/20/2013 06:10 PM, Tang Chen wrote: >> pageblock_nr_page should be pageblock_nr_pages, and fist is >> a typo of first. >> >> Signed-off-by: Tang Chen >> --- >> mm/page_isolation.c | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >> index 383bdbb..0cee10f 100644 >> --- a/mm/page_isolation.c >> +++ b/mm/page_isolation.c >> @@ -226,9 +226,9 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, >> int ret; >> >> /* >> - * Note: pageblock_nr_page != MAX_ORDER. Then, chunks of free page >> - * is not aligned to pageblock_nr_pages. >> - * Then we just check pagetype fist. >> + * Note: pageblock_nr_pages != MAX_ORDER. Then, chunks of free pages > > pageblock_nr_pages is the count of pages while MAX_ORDER is a order. Here > may be pageblock_order != MAX_ORDER. Hum, yes. Since we have: #define pageblock_nr_pages (1UL << pageblock_order) it should be pageblock_order. > >> + * are not aligned to pageblock_nr_pages. >> + * Then we just check migratetype first. >> */ >> for (pfn = start_pfn; pfn< end_pfn; pfn += pageblock_nr_pages) { >> page = __first_valid_page(pfn, pageblock_nr_pages); >> @@ -238,7 +238,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, >> page = __first_valid_page(start_pfn, end_pfn - start_pfn); >> if ((pfn< end_pfn) || !page) >> return -EBUSY; >> - /* Check all pages are free or Marked as ISOLATED */ >> + /* Check all pages are free or marked as ISOLATED */ >> zone = page_zone(page); >> spin_lock_irqsave(&zone->lock, flags); >> ret = __test_page_isolated_in_pageblock(start_pfn, end_pfn, > >