From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulators: max8973: initial DT support
Date: Mon, 24 Jun 2013 22:23:18 +0400 [thread overview]
Message-ID: <51C88E96.2010408@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1306241246580.19735@axis700.grange>
Hello.
On 06/24/2013 02:50 PM, Guennadi Liakhovetski wrote:
> This patch adds primitive DT support to the max8973 regulator driver. None
> of the configuration parameters, supported in the platform data are yet
> available in DT, therefore no configuration is performed if booting with
> no platform data. This means, that DT instantiation can only be used on
> boards, where no run-time configuration of the chip is required. In such
> cases the driver can be used to scale its output voltage. In the future
> support for configuration parameters should be added.
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
> v2: as suggested by Mark, regulator bindings are now directly under the
> main max8973 I2C device node.
> .../bindings/regulator/max8973-regulator.txt | 21 +++++++++++
> drivers/regulator/max8973-regulator.c | 37 +++++++++++++------
> 2 files changed, 46 insertions(+), 12 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> diff --git a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> new file mode 100644
> index 0000000..8d38ab2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> @@ -0,0 +1,21 @@
> +* Maxim MAX8973 Voltage Regulator
> +
> +Required properties:
> +
> +- compatible: must be "maxium,max8973"
I see only "maxim" and "dallas" for Maxim Integrated Products in
Documentation/devicetree/bindings/vendor-prefixes.txt. Is "maxium" some
new, unknown vendor?
> +- reg: the i2c slave address of the regulator. It should be 0x1b.
> +
> +Any standard regulator properties can be used to configure the single max8973
> +DCDC.
> +
> +Example:
> +
> + max8973@1b {
> + compatible = "maxium,max8973";
> + reg = <0x1b>;
> +
> + regulator-min-microvolt = <935000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c
> index b2dbdd7..0c5195a 100644
> --- a/drivers/regulator/max8973-regulator.c
> +++ b/drivers/regulator/max8973-regulator.c
[...]
> @@ -439,16 +447,21 @@ static int max8973_probe(struct i2c_client *client,
[...]
> + if (pdata) {
> + ret = max8973_init_dcdc(max, pdata);
> + if (ret < 0) {
> + dev_err(max->dev, "Max8973 Init failed, err = %d\n", ret);
Not "MAX8973"?
WBR, Sergei
next prev parent reply other threads:[~2013-06-24 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 10:50 [PATCH v2 2/2] regulators: max8973: initial DT support Guennadi Liakhovetski
2013-06-24 14:30 ` Mark Brown
2013-06-24 18:23 ` Sergei Shtylyov [this message]
2013-06-24 21:10 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C88E96.2010408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=broonie@kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).