Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

From: Namhyung Kim <namhyung.kim@lge.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Greg Price <price@MIT.EDU>, Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	David Ahern <dsahern@gmail.com>,
	Pekka Enberg <penberg@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf report: Add option to collapse undesired parts of call graph
Date: Tue, 25 Jun 2013 17:01:47 +0900	[thread overview]
Message-ID: <51C94E6B.6000802@lge.com> (raw)
In-Reply-To: <20130625074734.GD11420@gmail.com>

Hi,

2013-06-25 PM 4:47, Ingo Molnar wrote:
>
> * Greg Price <price@MIT.EDU> wrote:
>
>>> It would also be nice if all these visualization variants were available
>>> in the GTK front-end.
>>
>> TBH I'm not really familiar with the GTK front-end, as I mainly use
>> the TUI.  At a quick trial, it looks like --blackbox has the expected
>> effect on the display there; though with or without --blackbox I can't
>> seem to get the entries to expand to show me a call-graph profile, so
>> it's hard to demonstrate it fully.  Not sure what I may have done
>> wrong in building or running perf to make that not work (or is that
>> expected?)

Currently perf GTK front-end does not support callchains at all. 
There's a floating patchset to enable it though.

https://lkml.org/lkml/2013/6/4/181

>>
>> What changes do you have in mind to make these available in the GTK
>> front-end?
>
> I was thinking of something obvious like right-clicking it to make that
> function back boxed away or so? Have no firm ideas - maybe the GTK gents
> on Cc: know how to best integrate such features.

We don't support context menu yet.  Frankly, perf GTK code is still 
premature and needs some love.  Any contribution should be welcomed!

Thanks,
Namhyung