From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755194AbcKVK1H (ORCPT ); Tue, 22 Nov 2016 05:27:07 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:43290 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbcKVK1G (ORCPT ); Tue, 22 Nov 2016 05:27:06 -0500 Subject: Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect To: Axel Haslam , References: <20161121161541.27048-1-ahaslam@baylibre.com> <20161121161541.27048-4-ahaslam@baylibre.com> CC: , From: Sekhar Nori Message-ID: <51a13cb8-082c-c6c8-c1a1-c39de252d022@ti.com> Date: Tue, 22 Nov 2016 15:56:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161121161541.27048-4-ahaslam@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: > Currently the mmc driver is polling the gpio to know if the > card was removed. > > By using a gpio descriptor instead of the platform callbacks, the > driver will be able to register the gpio with the mmc core with API's > designed for this purpose. > > This has the advantage that an irq will be registered, > and polling is no longer needed. Also, platform callbacks can be removed. > > Signed-off-by: Axel Haslam This patch looks good, provided it is not based of 1/3 and 2/3. There are other boards in mach-davinci using the card detect and wp callbacks. And some like board-dm365-evm.c have those pins routed through a CPLD. So I guess there is more work to be done before platform callbacks can completely be removed from MMC/SD driver. But the closer we get, the better it is :) Thanks, Sekhar