From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12EDC433EF for ; Tue, 24 May 2022 10:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236375AbiEXKuA (ORCPT ); Tue, 24 May 2022 06:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiEXKt6 (ORCPT ); Tue, 24 May 2022 06:49:58 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45F1D5F8DA; Tue, 24 May 2022 03:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653389397; x=1684925397; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=Tk/huaI+Brj6VolyTS3vaRaaffgo18jJiY/piQh5zVQ=; b=JMxdD/KNFlqL2GSVFSTx3Owy9pgL4I27Vp7arGu5oDpqZzC3tGfikt3+ K2CzFZTNgbq/UfqsSyBW1FfXuTvUztDXQG2CBDv30GDvd3algQDBZoQxK 5nyvdqZJ3svKIJYhzU2CPXY73Ig7+HusftXvy0wLhWB4HaNtRpx0gLnyD A=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 May 2022 03:49:56 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 03:49:56 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 03:49:55 -0700 Received: from [10.216.5.195] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 03:49:49 -0700 Message-ID: <51b8aca1-e038-4907-e973-ebdbebaf9b28@quicinc.com> Date: Tue, 24 May 2022 16:19:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS Content-Language: en-US To: Stephen Boyd , , , , , , , , , , , , , , , , , References: <1652877755-25120-1-git-send-email-quic_srivasam@quicinc.com> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/2022 8:43 AM, Stephen Boyd wrote: Thanks for your time Stephen!!! > Quoting Srinivasa Rao Mandadapu (2022-05-18 05:42:35) >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index da1ad7e..445e481 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -1333,6 +1337,10 @@ static int qcom_swrm_probe(struct platform_device *pdev) >> ctrl->bus.compute_params = &qcom_swrm_compute_params; >> ctrl->bus.clk_stop_timeout = 300; >> >> + ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr"); >> + if (IS_ERR(ctrl->audio_cgcr)) >> + dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6.0\n"); > Why is there no return on error here? Is the reset optional? Yes it's optional. For older platforms this is not required. > >> + >> ret = qcom_swrm_get_port_config(ctrl); >> if (ret) >> goto err_clk;