From: Jiada Wang <jiada_wang@mentor.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <horms@verge.net.au>, <magnus.damm@gmail.com>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <geert@linux-m68k.org>,
<linux-renesas-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available
Date: Wed, 13 Mar 2019 15:36:49 +0900 [thread overview]
Message-ID: <51be4cda-aa39-ce95-e7ef-404d9b02f188@mentor.com> (raw)
In-Reply-To: <87ef7bguqn.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san
On 2019/03/13 15:33, Kuninori Morimoto wrote:
>
> Hi Jiada
>
>>> Some of SoCs have both basic and extended dmac registers set
>>> basic set only supports busif0 ~ busif3, in order to use
>>> busif4 ~ busif7, extended audio dmac registers need to be used.
>>>
>>> This patch changes to use extended dmac registers set when it is
>>> available in device-tree.
>>>
>>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>>> ---
>>
>> 1st of all, if you want to post this kind of patch-set,
>> you *should* post driver side patch 1st, and if it was accepted,
>> you need to post SoC side patch. Then, you need to indicate
>> to SoC maintainer which branch/commit should be based.
>> Otherwise, it will 100% breaks git-bisect.
>
> Grr, orz
> my head was 100% broken.
> This time, your patch doesn't breaks git-bisect.
> I'm so sorry.
>
right, no problem.
anyway, keep driver change before dts change,
is always a good practice
Thanks,
Jiada
> Best regards
> ---
> Kuninori Morimoto
>
next prev parent reply other threads:[~2019-03-13 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 5:58 [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available Jiada Wang
2019-03-13 6:23 ` Kuninori Morimoto
2019-03-13 6:33 ` Kuninori Morimoto
2019-03-13 6:36 ` Jiada Wang [this message]
2019-03-13 6:34 ` Jiada Wang
2019-03-13 6:57 ` Kuninori Morimoto
2019-03-13 8:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51be4cda-aa39-ce95-e7ef-404d9b02f188@mentor.com \
--to=jiada_wang@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).