linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: <jim_baxter@mentor.com>, <linux-i2c@vger.kernel.org>
Cc: Peter Korsgaard <peter.korsgaard@barco.com>,
	Wolfram Sang <wsa@the-dreams.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use.
Date: Fri, 9 Sep 2016 22:40:37 +0200	[thread overview]
Message-ID: <51c45bae-aa5d-bfad-e9d0-d95deb3dc380@axentia.se> (raw)
In-Reply-To: <1473278729-16329-1-git-send-email-jim_baxter@mentor.com>

On 2016-09-07 22:05, jim_baxter@mentor.com wrote:
> From: Jim Baxter <jim_baxter@mentor.com>
> 
> This patchset adds a new i2c_mux_add_reparented_adapter API to the i2c
> that allows owning modules to use module_get/module_put and stop the
> i2c bus module being removed whilst in use.
> 
> This was tested on an ARM i.MX6 Sabre board with the pca953x gpio module.
> 
> Joshua Frkuska (2):
>   i2c-mux: add i2c_mux_add_reparented_adapter api
>   i2c-mux-gpio: call i2c_add_reparented_mux_adapter

nitpick: Patch subjects for the second patch is wrong.

"reparented" is a bit dual when dealing with i2c adapter trees.
i2c_mux_add_owned_adapter is perhaps clearer?

Aside from that, I'm not using modules much and need some enlightenment
as to why the i2c_del_mux_adapter() call in i2c_mux_gpio_remove() is not
sufficient and what exactly the problem is? Why would someone/something
unload the i2c-mux module prematurely?

Would it be an alternative to make i2c-mux a proper kernel object of
some kind? I mean, why do not all other mux users also need to modify
the owner? Why is i2c-mux-gpio special?

CHeers,
Peter

  parent reply	other threads:[~2016-09-10  7:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 20:05 [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use jim_baxter
2016-09-07 20:05 ` [PATCH v1 1/2] i2c-mux: add i2c_mux_add_reparented_adapter api jim_baxter
2016-09-07 20:05 ` [PATCH v1 2/2] i2c-mux-gpio: call i2c_add_reparented_mux_adapter jim_baxter
2016-09-09 20:40 ` Peter Rosin [this message]
2016-09-13 16:55   ` [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use Baxter, Jim
2016-09-14 12:57     ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51c45bae-aa5d-bfad-e9d0-d95deb3dc380@axentia.se \
    --to=peda@axentia.se \
    --cc=jim_baxter@mentor.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.korsgaard@barco.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).