From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F5A6C433DF for ; Tue, 9 Jun 2020 15:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DADDC2072F for ; Tue, 9 Jun 2020 15:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="TmT0LsDP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730981AbgFIPvC (ORCPT ); Tue, 9 Jun 2020 11:51:02 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:25220 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730640AbgFIPvA (ORCPT ); Tue, 9 Jun 2020 11:51:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591717860; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=L2RvbGPsA2kvMC3pVbmeJgOrqYdiDNvCRMHV2qaWaZg=; b=TmT0LsDPDmXmpiFm8S/3S1TrPuBsX9CspzljA9LT6AXfYuINdmFwiOD1GZvLEtuLlHFIRoLo 2NKUh97qcMjRbmzF13P09YVJsdM82QT8jToti9F+tRoJirSxguHQGjQN0segjnrfnKmOU4Jp wvBlndNweuML6A6ln/SW/zNCqMs= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 5edfafd4fe1db4db899d6123 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Jun 2020 15:50:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 63AD0C433A0; Tue, 9 Jun 2020 15:50:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: gubbaven) by smtp.codeaurora.org (Postfix) with ESMTPSA id D666DC433CA; Tue, 9 Jun 2020 15:50:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 09 Jun 2020 21:20:43 +0530 From: gubbaven@codeaurora.org To: Markus Elfring Cc: linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Balakrishna Godavarthi , hemantg@codeaurora.org, Johan Hedberg , Marcel Holtmann , Matthias Kaehlcke , Rocky Liao , Rob Herring , Sean Paul , Claire Chang , yshavit@google.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout In-Reply-To: References: Message-ID: <51c4dfe5daf8497bd99a013458d93b92@codeaurora.org> X-Sender: gubbaven@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, Sure we will update in next patch set. Regards, Lakshmi Narayna. On 2020-06-04 23:54, Markus Elfring wrote: >> Due to race conditions between qca_hw_error and qca_controller_memdump >> during SSR timeout,the same pointer is freed twice. > > This is an unfortunate software situation. > > >> Which results to double free error. > > How do you think about to omit this sentence from the change > description? > > >> Now a lock is acquired while SSR state moved to timeout. > > I suggest to convert this information into an imperative wording. > > Would you like to add the tag “Fixes” to the commit message? > > Regards, > Markus