From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A252FC4167B for ; Fri, 13 May 2022 06:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377485AbiEMGx6 (ORCPT ); Fri, 13 May 2022 02:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377455AbiEMGx4 (ORCPT ); Fri, 13 May 2022 02:53:56 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2A409266E1D; Thu, 12 May 2022 23:53:50 -0700 (PDT) Received: from NTHCCAS01.nuvoton.com (NTHCCAS01.nuvoton.com [10.1.8.28]) by maillog.nuvoton.com (Postfix) with ESMTP id 7D6781C80DC4; Fri, 13 May 2022 14:53:49 +0800 (CST) Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.7; Fri, 13 May 2022 14:53:49 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 13 May 2022 14:53:48 +0800 Message-ID: <51ce4fca-f7b8-92ab-c9c6-1e57a2a5b5f3@nuvoton.com> Date: Fri, 13 May 2022 14:53:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC Content-Language: en-US To: Arnd Bergmann , Krzysztof Kozlowski CC: Linux Kernel Mailing List , DTML , linux-clk , "Linux ARM" , , "Rob Herring" , Stephen Boyd , "Krzysztof Kozlowski" , Olof Johansson , "Catalin Marinas" , Will Deacon , SoC Team , References: <20220510032558.10304-1-ychuang3@nuvoton.com> <8be62b40-077a-7634-7d34-7776909a2abe@linaro.org> From: Jacky Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/12 下午 10:35, Arnd Bergmann wrote: > On Thu, May 12, 2022 at 4:11 PM Krzysztof Kozlowski > wrote: >> On 10/05/2022 09:07, Arnd Bergmann wrote: >>> On Tue, May 10, 2022 at 5:25 AM Jacky Huang wrote: >>>> This patch series adds initial support for Nuvoton MA35D1 SoC, >>>> include initial dts and clock controller binding. >>>> >>> This looks fine in principle, but we are getting close to the merge window and >>> should finalize this quickly to make it into v5.19. I see that you don't have a >>> console device, as commented in the .dts patch. Normally I prefer merging >>> platforms only when there is at least rudimentary support for booting into >>> an initramfs with a serial console, but this is a flexible rule. >> I disagree. It does not look fine - does not pass `make dtbs_check` even >> with Nuvoton bindings... > Ok, thanks for taking a look. It was already late for 5.19 and missing the uart > driver, so it was clear it had not seen actual runtime testing. Let's try > aiming for 5.20 then. > > Arnd Thanks for your review and help. I will run the dtbs_check, add binding document, and include serial driver in the next version. sincerely, Jacky Huang