From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: afzal mohammed <afzal.mohd.ma@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] ARM: ep93xx: Replace setup_irq() by request_irq()
Date: Sun, 1 Mar 2020 17:21:51 +0100 [thread overview]
Message-ID: <51cebbbb-3ba4-b336-82a9-abcc22f9a69c@gmail.com> (raw)
In-Reply-To: <20200301122112.3847-1-afzal.mohd.ma@gmail.com>
Hi Afzal, Arnd,
as there is no dedicated tree for EP93xx, could you please
consider the below patch for your arm-soc tree?
On 01/03/2020 13:21, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> Hi sub-arch maintainers,
>
> If the patch is okay, please take it thr' your tree.
>
> Regards
> afzal
>
> v3:
> * Split out from series, also create subarch level patch as Thomas
> suggested to take it thr' respective maintainers
> * Modify string displayed in case of error as suggested by Thomas
> * Re-arrange code as required to improve readability
> * Remove irrelevant parts from commit message & improve
>
> v2:
> * Replace pr_err("request_irq() on %s failed" by
> pr_err("%s: request_irq() failed"
> * Commit message massage
>
> arch/arm/mach-ep93xx/timer-ep93xx.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> index de998830f534..dd4b164d1831 100644
> --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> @@ -117,15 +117,11 @@ static irqreturn_t ep93xx_timer_interrupt(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -static struct irqaction ep93xx_timer_irq = {
> - .name = "ep93xx timer",
> - .flags = IRQF_TIMER | IRQF_IRQPOLL,
> - .handler = ep93xx_timer_interrupt,
> - .dev_id = &ep93xx_clockevent,
> -};
> -
> void __init ep93xx_timer_init(void)
> {
> + int irq = IRQ_EP93XX_TIMER3;
> + unsigned long flags = IRQF_TIMER | IRQF_IRQPOLL;
> +
> /* Enable and register clocksource and sched_clock on timer 4 */
> writel(EP93XX_TIMER4_VALUE_HIGH_ENABLE,
> EP93XX_TIMER4_VALUE_HIGH);
> @@ -136,7 +132,9 @@ void __init ep93xx_timer_init(void)
> EP93XX_TIMER4_RATE);
>
> /* Set up clockevent on timer 3 */
> - setup_irq(IRQ_EP93XX_TIMER3, &ep93xx_timer_irq);
> + if (request_irq(irq, ep93xx_timer_interrupt, flags, "ep93xx timer",
> + &ep93xx_clockevent))
> + pr_err("Failed to request irq %d (ep93xx timer)\n", irq);
> clockevents_config_and_register(&ep93xx_clockevent,
> EP93XX_TIMER123_RATE,
> 1,
>
next prev parent reply other threads:[~2020-03-01 16:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 12:21 [PATCH v3] ARM: ep93xx: Replace setup_irq() by request_irq() afzal mohammed
2020-03-01 16:21 ` Alexander Sverdlin [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-01 12:23 [PATCH v3] ARM: orion: replace " afzal mohammed
2020-03-01 15:44 ` Andrew Lunn
2020-03-08 14:37 ` afzal mohammed
2020-03-09 16:17 ` Gregory CLEMENT
2020-03-13 20:39 ` Gregory CLEMENT
2020-03-01 12:23 [PATCH v3] ARM: spear: " afzal mohammed
2020-03-02 3:17 ` Viresh Kumar
2020-03-01 12:22 [PATCH v3] ARM: mmp: " afzal mohammed
2020-03-08 14:53 ` afzal mohammed
2020-03-08 16:19 ` Lubomir Rintel
2020-03-01 12:22 ` [PATCH v3] ARM: iop32x: " afzal mohammed
2020-03-09 12:19 ` [PATCH v3] ARM: mmp: " afzal mohammed
2020-03-01 12:19 [PATCH v3] ARM: OMAP: " afzal mohammed
2020-03-04 16:34 ` Tony Lindgren
2020-03-13 15:45 ` [PATCH v3] ARM: " afzal mohammed
2020-03-17 4:37 ` afzal mohammed
2020-03-25 11:43 ` afzal mohammed
2020-03-27 10:46 ` afzal mohammed
2020-03-27 10:55 ` Arnd Bergmann
2020-03-27 11:10 ` afzal mohammed
2020-03-27 11:29 ` afzal mohammed
2020-03-27 11:58 ` Arnd Bergmann
2020-03-27 12:41 ` [PATCH v4 1/5] ARM: ep93xx: Replace " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 2/5] ARM: spear: replace " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 3/5] ARM: cns3xxx: " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 4/5] ARM: mmp: " afzal mohammed
2020-03-27 12:44 ` [PATCH v4 5/5] ARM: iop32x: " afzal mohammed
2020-03-27 12:53 ` [PATCH v3] ARM: " afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51cebbbb-3ba4-b336-82a9-abcc22f9a69c@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=arnd@arndb.de \
--cc=hsweeten@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).