From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7C9C433E1 for ; Fri, 29 May 2020 13:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23E51206A1 for ; Fri, 29 May 2020 13:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgE2Nzv (ORCPT ); Fri, 29 May 2020 09:55:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:11184 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726965AbgE2Nzs (ORCPT ); Fri, 29 May 2020 09:55:48 -0400 IronPort-SDR: 0uCEDg2PM7an/i8S8NJlOJ8gVAJvbKUYMAZsn/LW3/6KaDZvS37Q84acFi/nVNKZYRFbI1YHaS /Qb0wsGFrinQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2020 06:55:48 -0700 IronPort-SDR: 68woBhYwyCb/XPXcZ4/cDoImYUxmuy0sIQn2hcjALc0Gx5CtwOS4ScXcytAZEUbe/+B+jII/4c g/ZQbyJHQzfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,448,1583222400"; d="scan'208";a="257341074" Received: from glmisa-mobl1.amr.corp.intel.com (HELO [10.251.9.114]) ([10.251.9.114]) by fmsmga008.fm.intel.com with ESMTP; 29 May 2020 06:55:47 -0700 Subject: Re: linux-next: build warning after merge of the sound-asoc tree To: Mark Brown , Stephen Rothwell Cc: Liam Girdwood , Linux Next Mailing List , Linux Kernel Mailing List , Ranjani Sridharan References: <20200528135717.3e2d5169@canb.auug.org.au> <20200529133054.GN4610@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <51d951b7-f31a-35e4-589b-a538e3a030ba@linux.intel.com> Date: Fri, 29 May 2020 08:55:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529133054.GN4610@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/20 8:30 AM, Mark Brown wrote: > On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the sound-asoc tree, today's linux-next build (x86_64 >> allmodconfig) produced this warning: >> >> sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not used [-Wunused-function] >> 464 | static int byt_remove(struct snd_sof_dev *sdev) >> | ^~~~~~~~~~ >> sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but not used [-Wunused-function] >> 454 | static int byt_resume(struct snd_sof_dev *sdev) >> | ^~~~~~~~~~ >> sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but not used [-Wunused-function] >> 447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 target_state) >> | ^~~~~~~~~~~ >> >> Introduced by commits >> >> ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks") >> c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op") > > Ranjani, Pierre? Humm, I am not sure what happened here or why kbuild didn't report this earlier. This was added in ddcccd543f5dbd ('ASoC: SOF: Intel: byt: Add PM callbacks') And I do see them used in the code: sound/soc/sof/intel/byt.c /* PM */ .suspend = byt_suspend, .resume = byt_resume, Will run a check and fix ASAP, my guess it's a Kconfig issue or the functions not protected by the usual SND_SOC_SOF_BAYTRAIL.