From: adhudase@codeaurora.org
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, okukatla@codeaurora.org,
mka@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: Do not skip aggregation for disabled paths
Date: Tue, 21 Jul 2020 20:50:16 +0530 [thread overview]
Message-ID: <51df476d9b3470a545042bd34812c79c@codeaurora.org> (raw)
In-Reply-To: <20200721120740.3436-1-georgi.djakov@linaro.org>
On 2020-07-21 17:37, Georgi Djakov wrote:
> When an interconnect path is being disabled, currently we don't
> aggregate
> the requests for it afterwards. But the re-aggregation step shouldn't
> be
> skipped, as it may leave the nodes with outdated bandwidth data. This
> outdated data may actually keep the path still enabled and prevent the
> device from going into lower power states.
>
> Reported-by: Atul Dhudase <adhudase@codeaurora.org>
> Fixes: 7d374b209083 ("interconnect: Add helpers for enabling/disabling
> a path")
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
Tested-by: Atul Dhudase <adhudase@codeaurora.org>
Reviewed-by: Atul Dhudase <adhudase@codeaurora.org>
> drivers/interconnect/core.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 37d5ec970cc1..5174dcb31ab7 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -243,6 +243,7 @@ static int aggregate_requests(struct icc_node
> *node)
> {
> struct icc_provider *p = node->provider;
> struct icc_req *r;
> + u32 avg_bw, peak_bw;
>
> node->avg_bw = 0;
> node->peak_bw = 0;
> @@ -251,9 +252,14 @@ static int aggregate_requests(struct icc_node
> *node)
> p->pre_aggregate(node);
>
> hlist_for_each_entry(r, &node->req_list, req_node) {
> - if (!r->enabled)
> - continue;
> - p->aggregate(node, r->tag, r->avg_bw, r->peak_bw,
> + if (r->enabled) {
> + avg_bw = r->avg_bw;
> + peak_bw = r->peak_bw;
> + } else {
> + avg_bw = 0;
> + peak_bw = 0;
> + }
> + p->aggregate(node, r->tag, avg_bw, peak_bw,
> &node->avg_bw, &node->peak_bw);
> }
prev parent reply other threads:[~2020-07-21 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 12:07 [PATCH] interconnect: Do not skip aggregation for disabled paths Georgi Djakov
2020-07-21 13:31 ` Sibi Sankar
2020-07-21 15:20 ` adhudase [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51df476d9b3470a545042bd34812c79c@codeaurora.org \
--to=adhudase@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=okukatla@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).