From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031753AbdADTIH (ORCPT ); Wed, 4 Jan 2017 14:08:07 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36461 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067AbdADQix (ORCPT ); Wed, 4 Jan 2017 11:38:53 -0500 Subject: Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c To: Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org References: <1483448495-31607-1-git-send-email-boris.brezillon@free-electrons.com> <1483448495-31607-11-git-send-email-boris.brezillon@free-electrons.com> Cc: David Woodhouse , Brian Norris , Cyrille Pitchen , Icenowy Zheng , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <51f2f7a3-56a7-1117-ab15-dd8eb59a4373@gmail.com> Date: Wed, 4 Jan 2017 16:15:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1483448495-31607-11-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/2017 02:01 PM, Boris Brezillon wrote: > Move Micron specific initialization logic into nand_micron.c. This is > part of the "separate vendor specific code from core" cleanup process. > > Signed-off-by: Boris Brezillon [...] > diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c > new file mode 100644 > index 000000000000..ddb9adf12c21 > --- /dev/null > +++ b/drivers/mtd/nand/nand_micron.c > @@ -0,0 +1,83 @@ > +/* > + * Copyright (C) 2013 Boris Brezillon 2013-2017 ? > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > + > +struct nand_onfi_vendor_micron { > + u8 two_plane_read; > + u8 read_cache; > + u8 read_unique_id; > + u8 dq_imped; > + u8 dq_imped_num_settings; > + u8 dq_imped_feat_addr; > + u8 rb_pulldown_strength; > + u8 rb_pulldown_strength_feat_addr; > + u8 rb_pulldown_strength_num_settings; > + u8 otp_mode; > + u8 otp_page_start; > + u8 otp_data_prot_addr; > + u8 otp_num_pages; > + u8 otp_feat_addr; > + u8 read_retry_options; > + u8 reserved[72]; > + u8 param_revision; > +} __packed; Is this __packed really needed? -- Best regards, Marek Vasut