From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbdLUPv0 (ORCPT ); Thu, 21 Dec 2017 10:51:26 -0500 Received: from mail-by2nam01on0075.outbound.protection.outlook.com ([104.47.34.75]:46050 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751143AbdLUPvV (ORCPT ); Thu, 21 Dec 2017 10:51:21 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, bp@alien8.de, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , =?UTF-8?B?UmFkaW0gS3LDhMKNbcODwqHDhQ==?= =?UTF-8?B?4oSi?= , Joerg Roedel , Borislav Petkov , Tom Lendacky , Herbert Xu , "David S . Miller" , Gary Hook , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v9 00/38] x86: Secure Encrypted Virtualization (AMD) To: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20171205010438.5773-1-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: <51fe0851-14d7-cb37-613c-0eaf8a7d2a65@amd.com> Date: Thu, 21 Dec 2017 09:51:14 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SN4PR0201CA0070.namprd02.prod.outlook.com (2603:10b6:803:20::32) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7a275fe8-ffff-4b0f-951c-08d5488aad3f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;3:hTRV8cE9UF1vvN4UcTVbheNonXqOmO7gheTAGJ8SjgLQ180WIM3HEYu6AtecMkvyf9P80PhnMtRG759VCHFMtqkmNFAcI64AvGGsJ6g7DZ7mU0ZvQmJ8YhRCUreUakyq3DPITg3xMyg2jkS7JrlGqtKdw6lO5qeiVPJ3JuYuGRzjhMRsPjK7K3SOraQf5SR5FdvNDjIkzkqPlwO+n1jtvmGXDF4+6HxqaSaPOlm+hbpBjDmskkKaH8pQw7eeHINE;25:1JYORXHYL1LmAHK0uUHI7EWG0VViEFwQppPIEuTaK85DUoETW+6sHQlEbf3WwcyJ93HkaTdImBn93pSypHzVAkU8fQP4v9LlTpgKF8VyvIp6lgasc6s/7J7jum7pRUR0FjXKcEryfcVtB2qxU4LA+lJVXP6N53VyAoRKtv+DctZgQfdnvFh6W5WPc+8UtqZ8o5z2ZN61lJFtjBN0FnIAcIedg7s20ettC+ei/X6HW7Qcl6znq9GYgmyrUylyPi5X1pXID7pD0HXDgq+epX1WatNFG/wTGEVkh+AR8e7Zp3uARed8y68pODyDz+YYr0DHjNsRuj0k6TIaH00ECDos94NrfE1leI23/MdilgOzOTE=;31:F2wbFmWZgoI/c2GFcjaBQj1eOJyfh8fFPjkQOuSk2GlSDkPZsWM+XSyy+mKXZr1MRSAMmUPHyYmpYXJ6Nv6jVjvhG9ckoJ0ecGivDRncsPhveS2T90FZopT3IjrhDXOTN2ZCx1SnxLJv5Cx71LC/MV4XveOhijYA3Up/BphAJWz+o1lUr/pHwecDo8ZwdPnKX6coK4fLoDddWjRrWtn1z3s+HVCGvcWySMbUY3/DID8= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:ujJ9Ydi7lMlVINf58M+ahi/vBC1sCk04D/9bKqXeIQjExC9FzbffZLngnphtXGERQg0Aa087tpnY8xzRMhYtkqg9+SqHXKPHPepu+l2ipsGBwiOLW+H8i3ahwN2X4epapzdArnmu6tIyoUNCA4TjuiX6MV5xxQmA8EO4Zk8jUnDbnKgjduqN4zrw43biT4at6Onm7Ch6Zy6JZhci0zTqOBf7mBtE2G8gFUd7Iwz7Xl91ELdQi5W9qeRXrHRxORghDj3kV8ERtKTjLVh3JxF8A4VjM8/4G1go6h+Uw4h3j6pVf5OWd/F/TpRu9FPoHLiU86OsBJskfOnEJXwvL8XLamQXSosBDsjxckgiwtTbjjToHQTpvR5mYxOhu7hlIr5hSVFpLBbNHqpUVtn1VB/aPI/J0fpN+HqAfgp64R27XVMlLaVCYlRU2dL98Fponiel/t1IauOV/Hn/71SZyRycTfoAGxgBzxamtqSdvD5eBB+w09ojsrBUCQVKw1iv7HgJ;4:7vljhEm3lvD52kjxtbhbECiIxI3vE+kyv5RPtDsfTjyVlmi4zqqYp+abqS66uijReC0SKCCVmavdpY/x7laAb+zWBNfilaJHdhqhrl0U4Mrt/B96tdTATNvGQD0H8hhf+L1YIo9LQptzE9QDhsz64/sktTV8USwfSV5LAWQTCXzS3DSpQAWAofHQvkmJP6KnGT5DPJjPmXZSWcdD3DdySdDbsND5AtFD8BkmYw5zy+Gc/25+VCUmg3xC4+vkeR/xb3KSMuERDrlINc+Yn/zbvA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(6055026)(6041268)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM2PR12MB0156;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0528942FD8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(376002)(346002)(366004)(39380400002)(39860400002)(396003)(24454002)(189003)(199004)(23676004)(83506002)(229853002)(52116002)(52146003)(68736007)(2486003)(31696002)(54906003)(86362001)(8936002)(81156014)(58126008)(316002)(65826007)(105586002)(6486002)(4326008)(65956001)(106356001)(66066001)(65806001)(64126003)(478600001)(36756003)(50466002)(47776003)(6512007)(76176011)(5660300001)(2870700001)(7416002)(97736004)(6666003)(81166006)(25786009)(16526018)(6246003)(6116002)(7736002)(2906002)(53546011)(3846002)(2950100002)(31686004)(305945005)(6506007)(53936002)(386003)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0156;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOk8yS0Jubk8rZ09SMjFsWHNlZTBIM0JtMTFQ?= =?utf-8?B?eWF4Vm5tRndOamMrM1gwRlExMm9MMmZrU0hxR2tDNjY5KzVySS91YjlUZ2do?= =?utf-8?B?ZTVGYjZFUTZNSFJIWERjd3UreEw0RHlLSmFIYlo1ZzBXWTYrSTgvdUhVempI?= =?utf-8?B?QXVPbWlQdWZtdjBkYzAvdVVjSnM4L2VDRUtPQzVCQnRDOVEvRkVOTUxYZGNw?= =?utf-8?B?VjE0Umw2NkJiRXNEckoyMEt6cFJLTyt0Z2lNd01XbHRXa0NkVGRMa3Ywb2hy?= =?utf-8?B?YktpallkT255Y2d6eXMzcXkyMU54d0k2NFQ1SGRvelBvWU0yQW00QVBqQzJF?= =?utf-8?B?VDh4TlFRTzY5UXRYWml1bWxTVW45azYyVFl6SFlQUTZzc25pVURObWd0VExq?= =?utf-8?B?YUt5a2lIZUExbFExRzA5bmw5NFFoVGVyclFMRElQTVFZcWRtOFBwSDZxc3Vm?= =?utf-8?B?QTh6aHFKS0llTjR2NWV3Vm1hdDlIT0IxY1JxRUs4RHdXSWlZODVydE8yL25Y?= =?utf-8?B?R2lPemdBSE9JalluRXhKdkhSRDZGTFhwNFdER2FneWVFRC8vQ2crOVFKaFlN?= =?utf-8?B?bGovUVI1OUJ1WGlIN2MvUm5paUcrSGMwcmF0QlY2eUhNanBLTjJObmFTSEJp?= =?utf-8?B?cFBoUytHcG90b1JmOGl4R1VVSkJRWXZCZzhLUEVFZlNHOUJMai90QkpaRENQ?= =?utf-8?B?VzduRnJ3VUJ0UHYrQUJ4WC9VaURndC9ETGVSQjU2c2U1MGJTdGl0RGdjQzBL?= =?utf-8?B?VXhrc0crUHhhR2xiaktya1QzTmEyRGxJcGpvUGx4eXh1QzJGQzdoblJrOTFT?= =?utf-8?B?Wkt5L1dOVVZwNEhFNEZieURVMTdJRWdxUUxzVjRJVWUyNG84ZDJyWUlKd0JR?= =?utf-8?B?Q1lRc3I2M1gvYXluVDhTQ0Q3dnkxc0xFU2svaXRkTDh1MWVQd3JOQVBQRFBD?= =?utf-8?B?d2kvKzdZQzlMb0dvUGwxVkI1cDI5NVFrbFpCTVBudWZyRjcwbWtZT3VZSDF0?= =?utf-8?B?Sjl6TENyUytuTVIzS25HOU9taTZkczJnZm00eS9YaTZsK25HREk0MmRXQ1hM?= =?utf-8?B?MXNFT0FDd0VsNnZidU1ncmp5d1VKQkJBNno2MUpySnFTcURPekM2SnVFRGtF?= =?utf-8?B?WVFhNll3TnVZU3JOTmVIZHlyNHQ2Y3A1RE9XUUFacWZzd1pKcUVseVdVVHNR?= =?utf-8?B?V09JdFJXNm9IdnZHS25YYWNIWG9YYVREKzdzM3FtQnBsTXoxcXZnVWZpQ3Br?= =?utf-8?B?OEtqTDVmRlRYOTV6bE5jd0RwQk9wUzdjdTg0UmlaaWtEMVg5VjdqNTRKR21o?= =?utf-8?B?ZmpoaHJnRGpPVUx4cERYUm9yZlBCa3E1Rkczc0w0Z2ptVlAvN2xGdS9JcWRL?= =?utf-8?B?eTVFQWNUYVZTNVlnR3Vqd0UyK21oVnFQK25QVzJwTWhQamxFNllEUUJtZHlB?= =?utf-8?B?Z2pYSTlPamlpcTZrU3labjcxekg0UUtqc3hUOExDZmY4eW1JSVBqMHNLY3BS?= =?utf-8?B?eHBGdmRWUnMxUHAyWi9FSVg4cmx6bUF2R3duOGhwMklnS0xyRzk3RkZML3Qx?= =?utf-8?B?TkU2bXFiamFXaytEYk96eUhaNFFucVVoZ1VRQWR5ZE1pMk5NNVVHWWJQRDFr?= =?utf-8?B?WnlISDluYUY5NjV6T0pMak1yUHJHNXRnV0J2Tyt5YXhqcmZkdG9QWC8wL2t3?= =?utf-8?B?SnNFcGdqZWNQQ2YyNzc0dVRVWGJPYmN6TmJNdFN2MUVTTXhqakR1UnQ0K1dy?= =?utf-8?B?d083dXZmWnZhZGxaQlA5K0VqZE9rRmJTRmxzTmE4OTNMdWZGWWwzOGgwUUJW?= =?utf-8?B?S1ZFNEVIZlZ4R1BjVE1xazNXbzN4NFBITlpITEM2blcySVE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;6:3YB4Ci712Sv9s783b8fGl4f27mdkuc7RTa/YmLY7TNQlHNgrESIeEUhqKib3cY16OjscwKAGsZJgr86x7oJemNkN9qlBimEniOR9TZdJBPyTOUOKjYyDW34yoRiC573gptWzQaYvh1JIwEi7aNKYn4SaE2qiAEbS2jPeVGHszjJ89E1xuS55qEvLXeOvh0NDuL7ZgrZczEKuNppff96mvJkInVPo7jtVSLIXWukcEJV+ngQ1h1CZPuuzgVAzT4nsOtHzWIO2Umo1mjlY295mjsiHsuFwjEKH7QJFmgceDAYrB6wELGO0Joh3ZDuPSHCvo45QkIBPrr+ElFTCCtzudWkGOt3VC1DfwxXuNgjwZoM=;5:HdI+1nEL8bW83Rj3eWrFst8HyZRTibTzFKCr823Ak8/RKSo5Awd0/+r8H7QBxVxXc9MS9VYvBcC94NsBuVPrtTP6vaEZQRJjBINzkHO3OK7AaYpucuUMLXA4Kntcj+Ao4ugo+gNxFTOkAyhyagoChc0EuIDG0UL0YSeRd+ZDu3s=;24:hfQ+SR4xA+HUcxncftkZllUfpXbfc6FRgXcGM2372kU1+b4Ztgh3q8vHNct2bXt+gJRFhnryx7ka5i7vOGZag8QWGKoevllUP3ygf5nBces=;7:luIm4X2CUQUcvzTEdf5nI0klOAZ+exIYortsWm95PDNmtOfIwLll4e3/2UzO7vxnCoFkABsrf2w65f7HmPJ81PM/tuKI7TwCOzpfqadPIDicr4nmdR3vsYmBeB4KRgBhZ9iBwsb35Y3oHVbUyyUmYUC89vtzZAxcCqeQ+2EkT+QkijDl0qeL2T1JPXt1CuQGHmgGzoN1CWCSL6h6d9B3ZL2vREylQZOqL1UY+5lvcvIZ2MBwXUCcdCHnt5UkDQiW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:R9zjkTU0F1SCpQ0re0zT1QCDioUM1iGH4cdWWkJj/5lGNQ/uoJAoS6OVRWfaA2xGPCGu7EJgUtq13psZlll9h7Nyszng8TYlwm95Sr1dIHY0c3lHVEHNn/A2bj4lb2XQk9JniWJeo8lHIROtngd4TQ3XpLNBWXR0AnRzl6xUh1L/M/nJEN/04Pq40WhpZCD1PEjLwpsKfPArDFhnuhcll+w5XuJATq6Dbd2ynRdwUM7/iU1IVlZk+JFfayvIffYz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 15:51:18.0073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a275fe8-ffff-4b0f-951c-08d5488aad3f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/17 7:06 AM, Paolo Bonzini wrote: .... Hi Paolo,   > Hi Brijesh, > > I have a couple comments: > > 1) how is MSR_AMD64_SEV's value passed to the guest, and where is it in > the manual? It is a non interceptable read-only MSR set by the HW when SEV feature is enabled in VMRUN instruction. > > 2) ECX should be 0 in the guest's 0x8000_001f leaf, because we don't > support nested SEV guests. Likewise, EAX bit 2 should be 0 since you > don't emulate the page flush MSR. IIRC, I do clear both EAX Page_Flush and nested virtualization case from Qemu SEV feature is enabled. > Both can be fixed on top (and I can do the second myself of course), so > there should be no need for a v10. Thanks