From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757931Ab3HHPof (ORCPT ); Thu, 8 Aug 2013 11:44:35 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:41195 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757906Ab3HHPod (ORCPT ); Thu, 8 Aug 2013 11:44:33 -0400 Message-ID: <5203BCDD.40809@wwwdotorg.org> Date: Thu, 08 Aug 2013 09:44:29 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Viresh Kumar CC: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren Subject: Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show() References: <568f3dbd414b050bb2319d960fb5044a5aed8ee3.1375964117.git.viresh.kumar@linaro.org> In-Reply-To: <568f3dbd414b050bb2319d960fb5044a5aed8ee3.1375964117.git.viresh.kumar@linaro.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2013 07:48 AM, Viresh Kumar wrote: > Lets use cpufreq_table_validate_and_show() instead of calling > cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). Assuming the new function simply does what the two removed lines do, this looks fine to me. > static int tegra_cpu_exit(struct cpufreq_policy *policy) > { > - cpufreq_frequency_table_cpuinfo(policy, freq_table); This doesn't seem to be mentioned in the commit description. I assume this is simply dead/useless code removal?