From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: <rafael.j.wysocki@intel.com>, <toshi.kani@hp.com>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()
Date: Fri, 9 Aug 2013 14:53:59 +0900 [thread overview]
Message-ID: <520483F7.9010408@jp.fujitsu.com> (raw)
In-Reply-To: <52045747.2060207@cn.fujitsu.com>
(2013/08/09 11:43), Gu Zheng wrote:
> Hi Ishimatsu-san,
> On 08/06/2013 06:11 PM, Yasuaki Ishimatsu wrote:
>
>> try_offline_node() checks that all cpus related with removed node have been
>> removed by using cpu_present_bits. If all cpus related with removed node have
>> been removed, try_offline_node() clears the node information.
>>
>> But try_offline_node() called from acpi_processor_remove() never clears
>> the node information. For disabling cpu_present_bits, acpi_unmap_lsapic()
>> need be called. But acpi_unmap_lsapic() is called after try_offline_node()
>> runs. So when try_offline_node() runs, the cpu's cpu_present_bits is always
>> set.
>>
>> This patch moves try_offline_node() after acpi_unmap_lsapic().
>
> It works well.
>
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
>
> Tested-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Thank you for testing.
Thanks,
Yasuaki Ishimatsu
>
> Thanks,
> Gu
>
>> ---
>> drivers/acpi/acpi_processor.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
>> index fd6c51c..5a74a9c 100644
>> --- a/drivers/acpi/acpi_processor.c
>> +++ b/drivers/acpi/acpi_processor.c
>> @@ -451,7 +451,6 @@ static void acpi_processor_remove(struct acpi_device *device)
>> /* Clean up. */
>> per_cpu(processor_device_array, pr->id) = NULL;
>> per_cpu(processors, pr->id) = NULL;
>> - try_offline_node(cpu_to_node(pr->id));
>>
>> /* Remove the CPU. */
>> get_online_cpus();
>> @@ -459,6 +458,8 @@ static void acpi_processor_remove(struct acpi_device *device)
>> acpi_unmap_lsapic(pr->id);
>> put_online_cpus();
>>
>> + try_offline_node(cpu_to_node(pr->id));
>> +
>> out:
>> free_cpumask_var(pr->throttling.shared_cpu_map);
>> kfree(pr);
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
>
prev parent reply other threads:[~2013-08-09 5:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 10:11 [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Yasuaki Ishimatsu
2013-08-06 16:56 ` Toshi Kani
2013-08-07 3:23 ` Yasuaki Ishimatsu
2013-08-09 7:28 ` Tang Chen
2013-08-09 22:16 ` Toshi Kani
2013-08-09 23:29 ` Rafael J. Wysocki
2013-08-10 2:11 ` Toshi Kani
2013-08-11 20:42 ` Rafael J. Wysocki
2013-08-12 20:08 ` Toshi Kani
2013-08-13 0:39 ` [PATCH] driver core / cpu: Check if NUMA node is valid before bringing CPU up Rafael J. Wysocki
2013-08-13 0:37 ` Toshi Kani
2013-08-09 2:43 ` [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Gu Zheng
2013-08-09 5:53 ` Yasuaki Ishimatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520483F7.9010408@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).