From: Stephen Warren <swarren@wwwdotorg.org>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
adi-buildroot-devel@lists.sourceforge.net,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH v2] pinctrl: pinmux: Don't free pins requested by other devices in pinmux_disable_setting.
Date: Mon, 12 Aug 2013 11:38:49 -0600 [thread overview]
Message-ID: <52091DA9.7080200@wwwdotorg.org> (raw)
In-Reply-To: <1376287821-22980-1-git-send-email-sonic.adi@gmail.com>
On 08/12/2013 12:10 AM, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> One peripheral may share part of its pins with the 2nd
> peripheral and the other pins with the 3rd. If it requests all pins
> when part of them has already be requested and owned by the 2nd
> peripheral, this request fails and pinmux_disable_setting() is called.
> The pinmux_disable_setting() frees all pins of the first peripheral
> without checking if the pin is owned by itself or the 2nd, which
> results in the malfunction of the 2nd peripheral driver.
This patch looks conceptually fine at a quick glance, but ...
> diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h
> @@ -154,6 +154,7 @@ struct pin_desc {
> const char *mux_owner;
> const struct pinctrl_setting_mux *mux_setting;
> const char *gpio_owner;
> + const struct pinctrl_setting *owning_setting
... I think you can use the existing "mux_setting" field instead of
adding a new "owning_setting" field.
prev parent reply other threads:[~2013-08-12 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 6:10 [PATCH v2] pinctrl: pinmux: Don't free pins requested by other devices in pinmux_disable_setting Sonic Zhang
2013-08-12 17:38 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52091DA9.7080200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).