From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: jbeulich@suse.com, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp()
Date: Fri, 27 May 2022 12:21:00 +0200 [thread overview]
Message-ID: <520d410e-7e71-971e-d21b-2c6dba20cd54@suse.com> (raw)
In-Reply-To: <20220503132207.17234-2-jgross@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1134 bytes --]
Ping?
On 03.05.22 15:22, Juergen Gross wrote:
> x86_has_pat_wp() is using a wrong test, as it relies on the normal
> PAT configuration used by the kernel. In case the PAT MSR has been
> setup by another entity (e.g. BIOS or Xen hypervisor) it might return
> false even if the PAT configuration is allowing WP mappings.
>
> Fixes: 1f6f655e01ad ("x86/mm: Add a x86_has_pat_wp() helper")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/mm/init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index d8cfce221275..71e182ebced3 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -80,7 +80,8 @@ static uint8_t __pte2cachemode_tbl[8] = {
> /* Check that the write-protect PAT entry is set for write-protect */
> bool x86_has_pat_wp(void)
> {
> - return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP;
> + return __pte2cachemode_tbl[__cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]] ==
> + _PAGE_CACHE_MODE_WP;
> }
>
> enum page_cache_mode pgprot2cachemode(pgprot_t pgprot)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-05-27 10:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 13:22 [PATCH 0/2] x86/pat: fix querying available caching modes Juergen Gross
2022-05-03 13:22 ` [PATCH 1/2] x86/pat: fix x86_has_pat_wp() Juergen Gross
2022-05-27 10:21 ` Juergen Gross [this message]
2022-06-14 15:09 ` Juergen Gross
2022-06-20 5:22 ` Thorsten Leemhuis
2022-06-20 5:30 ` Juergen Gross
2022-06-20 6:15 ` Thorsten Leemhuis
2022-06-20 10:26 ` Borislav Petkov
2022-06-20 10:41 ` Juergen Gross
2022-06-20 15:27 ` Dave Hansen
2022-06-20 15:34 ` Juergen Gross
2022-05-03 13:22 ` [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Juergen Gross
2022-05-04 8:31 ` Jan Beulich
2022-05-04 9:14 ` Juergen Gross
2022-05-04 9:51 ` Jan Beulich
2022-05-20 4:43 ` Chuck Zmudzinski
2022-05-20 5:56 ` Chuck Zmudzinski
2022-05-20 6:05 ` Jan Beulich
2022-05-20 6:59 ` Chuck Zmudzinski
2022-05-20 8:30 ` Chuck Zmudzinski
2022-05-20 9:41 ` Jan Beulich
2022-05-20 13:33 ` Chuck Zmudzinski
2022-05-20 14:06 ` Jan Beulich
2022-05-20 14:48 ` Chuck Zmudzinski
2022-05-21 10:47 ` Thorsten Leemhuis
2022-05-24 18:32 ` Chuck Zmudzinski
2022-05-25 7:45 ` Thorsten Leemhuis
2022-05-25 8:04 ` Juergen Gross
2022-05-25 8:37 ` Jan Beulich
2022-05-25 8:51 ` Thorsten Leemhuis
2022-05-25 19:25 ` Chuck Zmudzinski
2022-05-20 15:46 ` [REGRESSION} " Chuck Zmudzinski
2022-05-20 17:13 ` Chuck Zmudzinski
2022-05-20 17:17 ` Chuck Zmudzinski
2022-05-18 13:45 ` Christoph Hellwig
2022-05-20 2:15 ` Chuck Zmudzinski
2022-05-20 2:21 ` Chuck Zmudzinski
2022-05-21 13:24 ` Chuck Zmudzinski
2022-07-11 9:46 ` [tip: x86/urgent] x86/pat: Fix x86_has_pat_wp() tip-bot2 for Juergen Gross
2022-07-13 10:45 ` tip-bot2 for Juergen Gross
2022-07-13 10:52 ` tip-bot2 for Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520d410e-7e71-971e-d21b-2c6dba20cd54@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).