From: Qu Wenruo <wqu@suse.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Cc: broonie@kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: About regression caused by commit aea6cb99703e ("regulator: resolve supply after creating regulator")
Date: Sun, 8 Nov 2020 15:40:55 +0800 [thread overview]
Message-ID: <52106dff-aa57-da4b-dcc3-3dedba82a3e8@suse.com> (raw)
In-Reply-To: <c13f1683-97c9-40b4-f740-73eaceb7c98f@suse.com>
Also add Rockchip and device tree mail lists to the CC, just in case we
need to update the device tree for RK808.
On 2020/11/8 下午3:35, Qu Wenruo wrote:
> Hi Michał,
>
> Recently when testing v5.10-rc2, I found my RK3399 boards failed to boot
> from NVME.
>
> It turns out that, commit aea6cb99703e ("regulator: resolve supply after
> creating regulator") seems to be the cause.
>
> In RK3399 board, vpcie1v8 and vpcie0v9 of the pcie controller is
> provided by RK808 regulator.
> With that commit, now RK808 regulator fails to register:
>
> [ 1.402500] rk808-regulator rk808-regulator: there is no dvs0 gpio
> [ 1.403104] rk808-regulator rk808-regulator: there is no dvs1 gpio
> [ 1.419856] rk808 0-001b: failed to register 12 regulator
> [ 1.422801] rk808-regulator: probe of rk808-regulator failed with
> error -22
>
> Since voltages from rk808 are not proper registered, then it prevents
> the rockchip PCIE controller to find its voltage provider:
>
> [ 1.855276] rockchip_pcie_probe: parse_host_dt err=-517
>
>
> I currently tested with that commit reverted, then the RK808 works again.
>
> Is this a known regression? Or the RK808 device tree is out of spec?
>
> It would help a lot to fix the problem before the regression makes all
> RK3399 boards to lose their ability to initialize PCIE controller.
>
>
> BTW I didn't find that patch submitted to mail lists like
> linux-arm-kernel. I doubt if that commit really got enough testing from
> arm community, especially considering that currently ARM is the biggest
> user of device-tree and regulators.
>
> Maybe it's a good idea to also submit such patches to arm related mail
> lists next time?
>
> Thanks,
> Qu
>
next prev parent reply other threads:[~2020-11-08 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 7:35 About regression caused by commit aea6cb99703e ("regulator: resolve supply after creating regulator") Qu Wenruo
2020-11-08 7:40 ` Qu Wenruo [this message]
2020-11-08 17:18 ` Michał Mirosław
2020-11-08 23:28 ` Qu Wenruo
2020-11-22 14:43 ` Jan Kiszka
2020-11-22 16:35 ` Michał Mirosław
2020-11-23 6:47 ` Jan Kiszka
2020-11-23 8:01 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52106dff-aa57-da4b-dcc3-3dedba82a3e8@suse.com \
--to=wqu@suse.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).