From: Jon Hunter <jonathanh@nvidia.com>
To: Marcel Ziswiler <marcel@ziswiler.com>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator
Date: Fri, 12 Oct 2018 11:44:03 +0100 [thread overview]
Message-ID: <521e8eb0-ce63-851a-0637-a0207bec6a32@nvidia.com> (raw)
In-Reply-To: <20181009152523.3771-4-marcel@ziswiler.com>
On 09/10/18 16:25, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Fix HDMI requiring two regulators being enabled by a single GPIO. Model
> this using an intermediate reg_en_vdd_hdmi regulator being the
> vin-supply of them other two. This fixes the display subsystem and gets
> rid of the following error during boot:
>
> reg-fixed-voltage: probe of regulator-3v3-avdd-hdmi failed with error -16
> tegra-hdmi 54280000.hdmi: failed to get VDD regulator
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v1: None
>
> arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 16 ++++++++++++----
> arch/arm/boot/dts/tegra30-apalis.dtsi | 16 ++++++++++++----
> arch/arm/boot/dts/tegra30-colibri.dtsi | 16 ++++++++++++----
> 3 files changed, 36 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> index 02f8126481a2..065a24ac1052 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> @@ -1133,8 +1133,7 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_1v8_vio>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi {
> @@ -1143,8 +1142,7 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_module_3v3>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_5v0_charge_pump: regulator-5v0-charge-pump {
> @@ -1171,6 +1169,16 @@
> regulator-always-on;
> };
>
> + reg_en_vdd_hdmi: regulator-en-vdd-hdmi {
> + compatible = "regulator-fixed";
> + regulator-name = "EN_VDD_HDMI";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + enable-active-high;
> + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> + vin-supply = <®_module_3v3>;
> + };
> +
> sound {
> compatible = "toradex,tegra-audio-sgtl5000-apalis_t30",
> "nvidia,tegra-audio-sgtl5000";
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 7f112f192fe9..6727c5868425 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -1115,8 +1115,7 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_1v8_vio>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi {
> @@ -1125,8 +1124,7 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_module_3v3>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_5v0_charge_pump: regulator-5v0-charge-pump {
> @@ -1153,6 +1151,16 @@
> regulator-always-on;
> };
>
> + reg_en_vdd_hdmi: regulator-en-vdd-hdmi {
> + compatible = "regulator-fixed";
> + regulator-name = "EN_VDD_HDMI";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + enable-active-high;
> + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> + vin-supply = <®_module_3v3>;
> + };
> +
> sound {
> compatible = "toradex,tegra-audio-sgtl5000-apalis_t30",
> "nvidia,tegra-audio-sgtl5000";
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index 35af03ca9e90..963f26071415 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -965,8 +965,7 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_1v8_vio>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi {
> @@ -975,8 +974,7 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> - vin-supply = <®_module_3v3>;
> + vin-supply = <®_en_vdd_hdmi>;
> };
>
> reg_5v0_charge_pump: regulator-5v0-charge-pump {
> @@ -1012,6 +1010,16 @@
> regulator-always-on;
> };
>
> + reg_en_vdd_hdmi: regulator-en-vdd-hdmi {
> + compatible = "regulator-fixed";
> + regulator-name = "EN_VDD_HDMI";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + enable-active-high;
> + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
> + vin-supply = <®_module_3v3>;
> + };
> +
> sound {
> compatible = "toradex,tegra-audio-sgtl5000-colibri_t30",
> "nvidia,tegra-audio-sgtl5000";
>
Given Linus W's fix for the gpiolib [0], I am not convinced that this is
really better/needed.
Cheers
Jon
[0] https://lore.kernel.org/patchwork/patch/998354/
--
nvpublic
next prev parent reply other threads:[~2018-10-12 10:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 15:25 [PATCH v1 0/8] ARM: dts: tegra: last minute fixes Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 1/8] ARM: tegra: fix simple-panel compatibles Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 2/8] ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator Marcel Ziswiler
2018-10-12 10:44 ` Jon Hunter [this message]
2018-10-12 11:51 ` Marcel Ziswiler
2018-10-12 13:16 ` Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 4/8] ARM: tegra: colibri_t20: reorder pmic properties Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 5/8] ARM: tegra: apalis-tk1: further regulator clean-up Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 6/8] ARM: tegra: apalis_t30/tk1: annotate power I2C being on-module Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 7/8] ARM: tegra: colibri_t30: further regulator clean-up Marcel Ziswiler
2018-10-09 15:25 ` [PATCH v1 8/8] ARM: tegra: apalis_t30: " Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521e8eb0-ce63-851a-0637-a0207bec6a32@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).