From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EE8C5CFC1 for ; Tue, 19 Jun 2018 15:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B026205C9 for ; Tue, 19 Jun 2018 15:32:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B026205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966646AbeFSPcF (ORCPT ); Tue, 19 Jun 2018 11:32:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:32418 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966208AbeFSPcD (ORCPT ); Tue, 19 Jun 2018 11:32:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2018 08:32:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,243,1526367600"; d="scan'208";a="209344484" Received: from jagarci1-mobl.amr.corp.intel.com (HELO [10.254.79.227]) ([10.254.79.227]) by orsmga004.jf.intel.com with ESMTP; 19 Jun 2018 08:32:02 -0700 Subject: Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache To: Jarkko Sakkinen References: <20180608171216.26521-1-jarkko.sakkinen@linux.intel.com> <20180608171216.26521-10-jarkko.sakkinen@linux.intel.com> <3c1b04d6-6e93-efaa-1890-101b7fd9784c@intel.com> <20180619145753.GB8034@linux.intel.com> Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:INTEL SGX" From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <5226fbdc-dcad-4856-68bb-3219ab31b30d@intel.com> Date: Tue, 19 Jun 2018 08:32:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180619145753.GB8034@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/19/2018 07:57 AM, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 11:24:12AM -0700, Dave Hansen wrote: >>> Each subsystem that uses SGX must provide a set of callbacks for EPC >>> pages that are used to reclaim, block and write an EPC page. Kernel >>> takes the responsibility of maintaining LRU cache for them. >> >> What does a "subsystem that uses SGX" mean? Do we have one of those >> already? > > Driver and KVM. Could you just say "the SGX and driver both provide a set of callbacks"? >>> +struct sgx_secs { >>> + uint64_t size; >>> + uint64_t base; >>> + uint32_t ssaframesize; >>> + uint32_t miscselect; >>> + uint8_t reserved1[SGX_SECS_RESERVED1_SIZE]; >>> + uint64_t attributes; >>> + uint64_t xfrm; >>> + uint32_t mrenclave[8]; >>> + uint8_t reserved2[SGX_SECS_RESERVED2_SIZE]; >>> + uint32_t mrsigner[8]; >>> + uint8_t reserved3[SGX_SECS_RESERVED3_SIZE]; >>> + uint16_t isvvprodid; >>> + uint16_t isvsvn; >>> + uint8_t reserved4[SGX_SECS_RESERVED4_SIZE]; >>> +}; >> >> This is a hardware structure, right? Doesn't it need to be packed? > > Everything is aligned properly in this struct. The compiler doesn't guarantee the way you have it laid out. It might work today, but it's subject to being changed. >>> +enum sgx_tcs_flags { >>> + SGX_TCS_DBGOPTIN = 0x01, /* cleared on EADD */ >>> +}; >>> + >>> +#define SGX_TCS_RESERVED_MASK 0xFFFFFFFFFFFFFFFEL >> >> Would it be possible to separate out the SGX software structures from >> SGX hardware? It's hard to tell them apart. > > How do you draw the line in the architectural structures? I know then when I see them. "SGX_TCS_DBGOPTIN" - Hardware "SGX_NR_TO_SCAN" - Software Please at least make an effort to do this. >>> +#define SGX_NR_TO_SCAN 16 >>> +#define SGX_NR_LOW_PAGES 32 >>> +#define SGX_NR_HIGH_PAGES 64 >>> + >>> bool sgx_enabled __ro_after_init = false; >>> EXPORT_SYMBOL(sgx_enabled); >>> +bool sgx_lc_enabled __ro_after_init; >>> +EXPORT_SYMBOL(sgx_lc_enabled); >>> +atomic_t sgx_nr_free_pages = ATOMIC_INIT(0); >> >> Hmmm, global atomic. Doesn't sound very scalable. > > We could potentially remove this completely as banks have 'free_cnt' > field and use the sum when needed as the value. That seems prudent. >>> +struct sgx_epc_bank sgx_epc_banks[SGX_MAX_EPC_BANKS]; >>> +EXPORT_SYMBOL(sgx_epc_banks); >>> +int sgx_nr_epc_banks; >>> +EXPORT_SYMBOL(sgx_nr_epc_banks); >>> +LIST_HEAD(sgx_active_page_list); >>> +EXPORT_SYMBOL(sgx_active_page_list); >>> +DEFINE_SPINLOCK(sgx_active_page_list_lock); >>> +EXPORT_SYMBOL(sgx_active_page_list_lock); >> >> Hmmm, global spinlock protecting a page allocator linked list. Sounds >> even worse than at atomic. >> >> Why is this OK? > > Any suggestions what would be a better place in order to make a > fine grained granularity? The bank seems a logical place. Or, create a structure that actually hangs off NUMA nodes. BTW, do we *have* locality information for SGX banks? >>> +/** >>> + * sgx_try_alloc_page - try to allocate an EPC page >>> + * @impl: implementation for the struct sgx_epc_page >>> + * >>> + * Try to grab a page from the free EPC page list. If there is a free page >>> + * available, it is returned to the caller. >>> + * >>> + * Return: >>> + * a &struct sgx_epc_page instace, >>> + * NULL otherwise >>> + */ >>> +struct sgx_epc_page *sgx_try_alloc_page(struct sgx_epc_page_impl *impl) >>> +{ >>> + struct sgx_epc_bank *bank; >>> + struct sgx_epc_page *page = NULL; >>> + int i; >>> + >>> + for (i = 0; i < sgx_nr_epc_banks; i++) { >>> + bank = &sgx_epc_banks[i]; >> >> What's a bank? How many banks does a system have? > > AFAIK, UMA systems have one bank. NUMA have multiple. It is a physical > memory region reserved for enclave pages. That's great text to include near the structure definition for sgx_epc_bank. >>> + down_write(&bank->lock); >>> + >>> + if (atomic_read(&bank->free_cnt)) >>> + page = bank->pages[atomic_dec_return(&bank->free_cnt)]; >> >> Why is a semaphore getting used here? I don't see any sleeping or >> anything happening under this lock. > > Should be changed to reader-writer spinlock, thanks. Which also reminds me... It would be nice to explicitly call out why you need an atomic_t inside a lock-protected structure. >>> + } >>> + >>> + if (atomic_read(&sgx_nr_free_pages) < SGX_NR_LOW_PAGES) >>> + wake_up(&ksgxswapd_waitq); >>> + >>> + return entry; >>> +} >>> +EXPORT_SYMBOL(sgx_alloc_page); >> >> Why aren't these _GPL exports? > > Source files a dual licensed. Sounds like a great thing to ask your licensing or legal team about. >>> +/** >>> + * sgx_free_page - free an EPC page >>> + * >>> + * @page: any EPC page >>> + * >>> + * Remove an EPC page and insert it back to the list of free pages. >>> + * >>> + * Return: SGX error code >>> + */ >>> +int sgx_free_page(struct sgx_epc_page *page) >>> +{ >>> + struct sgx_epc_bank *bank = SGX_EPC_BANK(page); >>> + int ret; >>> + >>> + ret = sgx_eremove(page); >>> + if (ret) { >>> + pr_debug("EREMOVE returned %d\n", ret); >>> + return ret; >>> + } >>> + >>> + down_read(&bank->lock); >>> + bank->pages[atomic_inc_return(&bank->free_cnt) - 1] = page; >>> + atomic_inc(&sgx_nr_free_pages); >>> + up_read(&bank->lock); >>> + >>> + return 0; >>> +} >> >> bank->lock confuses me. This seems to be writing to a bank, but only >> needs a read lock. Why? > > It could be either way around: > > 1. Allow multiple threads that free a page to access the array. > 2. Allow multiple threads that alloc a page to access the array. Whatever way you choose, please document the locking scheme. >>> +/** >>> + * sgx_get_page - pin an EPC page >>> + * @page: an EPC page >>> + * >>> + * Return: a pointer to the pinned EPC page >>> + */ >>> +void *sgx_get_page(struct sgx_epc_page *page) >>> +{ >>> + struct sgx_epc_bank *bank = SGX_EPC_BANK(page); >>> + >>> + if (IS_ENABLED(CONFIG_X86_64)) >>> + return (void *)(bank->va + SGX_EPC_ADDR(page) - bank->pa); >>> + >>> + return kmap_atomic_pfn(SGX_EPC_PFN(page)); >>> +} >>> +EXPORT_SYMBOL(sgx_get_page); >> >> This is odd. Do you really want to detect 64-bit, or CONFIG_HIGHMEM? > > For 32-bit (albeit not supported at this point) it makes sense to always > use kmap_atomic_pfn() as the virtua address area is very limited. That makes no sense. 32-bit kernels have plenty of virtual address space if not using highmem. >>> +struct page *sgx_get_backing(struct file *file, pgoff_t index) >>> +{ >>> + struct inode *inode = file->f_path.dentry->d_inode; >>> + struct address_space *mapping = inode->i_mapping; >>> + gfp_t gfpmask = mapping_gfp_mask(mapping); >>> + >>> + return shmem_read_mapping_page_gfp(mapping, index, gfpmask); >>> +} >>> +EXPORT_SYMBOL(sgx_get_backing); >> >> What does shmem have to do with all this? > > Backing storage is an shmem file similarly is in drm. That's something good to call out in the changelog: how shmem gets used here. >>> +static __init bool sgx_is_enabled(bool *lc_enabled) >>> { >>> unsigned long fc; >>> >>> @@ -41,12 +466,26 @@ static __init bool sgx_is_enabled(void) >>> if (!(fc & FEATURE_CONTROL_SGX_ENABLE)) >>> return false; >>> >>> + *lc_enabled = !!(fc & FEATURE_CONTROL_SGX_LE_WR); >>> + >>> return true; >>> } >> >> I'm baffled why lc_enabled is connected to the enclave page cache. > > KVM works only with writable MSRs. Driver works both with writable > and read-only MSRs. Could you help with my confusion by documenting this a bit?