From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933217AbcHaIZs (ORCPT ); Wed, 31 Aug 2016 04:25:48 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:57346 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbcHaIZp (ORCPT ); Wed, 31 Aug 2016 04:25:45 -0400 From: Arnd Bergmann To: Andy Lutomirski Cc: Steven Rostedt , Marcin Nowakowski , Linux API , Ingo Molnar , open list , Linux MIPS Mailing List Subject: Re: [PATCH 1/2] tracing/syscalls: allow multiple syscall numbers per syscall Date: Wed, 31 Aug 2016 10:24:56 +0200 Message-ID: <5227283.eAVLXfitJh@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1472463007-6469-1-git-send-email-marcin.nowakowski@imgtec.com> <20160830152955.17633511@gandalf.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:SFcEq3DyCBfM/Z/YPQ3/y7XtRWhG0eyNZVklT//g7xMdb4SaGyr TuzhQIsii6ca2yNqkmqaF8Y8yERpIKW+F0QshQ2IsNvJGoV+YUKpC/nETyyi0MWiwZX2hgi wY4J3oWUNou0Lmtitnh4T89ikNL1ovo3LsSXybCmPHewjvkyoyFmmMsGRSdPmhFlp/Ah2qK 6ugJ+GeNnR503zcGfW3vw== X-UI-Out-Filterresults: notjunk:1;V01:K0:RxanQ44ZTkk=:OyfEKSzj2PfTJzbuyGyLVp XWGHcgw7e6/vtpm95M/L8qp+ivm1mpuHxZbQFPJCONF5AwdkJ93f/AQVFvDc7GNpkQ8LujxBH N8LZsDfaoPYzfO/j5UHe9I1npnuSAFci23OPTWOxMCoIm/vZ+3J7qac0fh1H5tiGHzcYh68Qi aFGW7fMQU7/pcvkS3vePRlfyaVLxP+rFbkiZYHJfp0RfSVJJHYfSf475yjShY6rGyvO7EGF1b msquNO8Y5hhGl1nsrC8/ZgudMba8a4WfHHBAL5pz2A9gCFYo+nAiJWSiZIyHYTIWQZZxsdASD TLiAKdkJqxPpRtaJRxCPaDEwjTZOXgmqm69m/05MDoEDG3qNqBsTpIcKOCsKWz/5lImS39kS1 b3Be/ojosmwcH+fgk2dEySyG4a6NkXRQScOwfp+Purcyrxzg3nzSsPaEq/WZ43j8vCBAHGJuN dcdcen8Hg9zHHjYtyYYlPKCKYFqpTXCdjSRc0GoIlc5kicDZmUtnN1uoMjv8dghhS31QmQ4l9 WMP9exx7sQJ4tA8r7kzA+3Ms0l5H5B8Azy4Gm49nkBFUw6BoU0012eMSIP9KEqDQILYl1CAgJ rtuRcUhxDGtGU+i7fosMTEbkIDX0cLp7eTJZsCmzorTd3xangs+eG4jfu537ROoDOyPRinGZA LifRmopypf6FGJMejOkVnVINca0faqJlNiP8+qfc0hLTU4Gge7+qAG1PU15SiWphC9ZLQzWXy iWqVp1krzq1MMjLl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, August 30, 2016 12:53:53 PM CEST Andy Lutomirski wrote: > Egads! OK, I see why this is a mess. > > I guess we should be creating the metadata from the syscall tables > instead of from the syscall definitions, but I guess that's currently > a nasty per-arch mess. > I've been thinking for a while about how to improve the situation around adding new syscalls, which currently involves adding a number and an entry in a .S file on most architectures (some already have their own method to simplify it, and others using a shared table in asm-generic). I was thinking of extending the x86 way of doing this to all architectures, and adding a way to have all future syscalls require only one addition in a single file that gets included by the architecture specific files for the existing syscalls. Assuming we do this, would that work for generating the metadata from the same file like we do with arch/x86/entry/syscalls/syscall{tbl,hdr}.sh ? Arnd