From: Rafael David Tinoco <rafael.tinoco@linaro.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
shuah@kernel.org
Subject: Re: [PATCH] proc: fix proc-self-map-files selftest for arm
Date: Mon, 15 Oct 2018 13:55:14 -0300 [thread overview]
Message-ID: <52504bd5-b4ed-518b-f748-c634172c6c68@linaro.org> (raw)
In-Reply-To: <20181011220009.GF2401@uranus.lan>
On 10/11/18 7:00 PM, Cyrill Gorcunov wrote:
> On Fri, Oct 12, 2018 at 12:30:06AM +0300, Alexey Dobriyan wrote:
>> On Fri, Oct 12, 2018 at 12:02:56AM +0300, Cyrill Gorcunov wrote:
>>> On Thu, Oct 11, 2018 at 11:56:01PM +0300, Alexey Dobriyan wrote:
>>>>
>>>> As the comment in the beginning says this test is specifically for addresss 0.
>>>> Maybe it should be ifdeffed with __arm__ then.
>>>
>>> Is there some other reason than allocating non-mergable VMA?
>>
>> IIRC the reason is to test address 0 as it is effectively banned
>> for userspace so if it will be broken, it will be broken silently
>> for a long time.
>
> This is rather a side effect of the test because the primary reason
> was to check procfs numbers conversion, right? Don't get me wrong,
> I don't mind about __arm__ define or similar, this is fine for
> one architecture, but if there comes more we will get a number
> of #ifdefs which is unrelated to procfs numeric routines at all.
That is what I also had in mind, thus the patch. I just realized we had
another issue on LKFT (our functional tests tool) for
proc-self-map-files-001.c. Test 001 does pretty much the same as 002,
but without the MAP_FIXED mmap flag.
Is it okay to consolidate both tests into just 1, and focus in checking
procfs numbers conversion only, rather than if mapping 0 is allowed or
not ? Can I send a v2 with that in mind ?
>
>> As for "unmergeable" libc here doesn't map /dev/zero. I know how to
>> avoid even theoretical breakage by creating binaries by hand but it
>> will be probably too much.
>
> Sure.
>
next prev parent reply other threads:[~2018-10-15 16:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:43 [PATCH] proc: fix proc-self-map-files selftest for arm Rafael David Tinoco
2018-10-11 19:42 ` Cyrill Gorcunov
2018-10-11 20:56 ` Alexey Dobriyan
2018-10-11 21:02 ` Cyrill Gorcunov
2018-10-11 21:30 ` Alexey Dobriyan
2018-10-11 22:00 ` Cyrill Gorcunov
2018-10-15 16:55 ` Rafael David Tinoco [this message]
2018-10-15 17:21 ` Cyrill Gorcunov
2018-11-08 10:41 ` Rafael David Tinoco
2018-11-08 11:11 ` Cyrill Gorcunov
2018-11-09 11:30 ` [PATCH] proc: fix and merge proc-self-map-file tests Rafael David Tinoco
2018-11-09 11:41 ` Cyrill Gorcunov
2018-11-09 11:45 ` Rafael David Tinoco
2018-11-09 11:48 ` Cyrill Gorcunov
2018-11-09 12:01 ` Rafael David Tinoco
2018-11-09 18:04 ` Cyrill Gorcunov
2018-11-09 18:48 ` Rafael David Tinoco
2018-11-09 19:39 ` Cyrill Gorcunov
2018-11-10 17:47 ` Alexey Dobriyan
2018-11-10 17:56 ` Rafael David Tinoco
2018-11-10 18:49 ` Alexey Dobriyan
2018-11-11 2:50 ` Rafael David Tinoco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52504bd5-b4ed-518b-f748-c634172c6c68@linaro.org \
--to=rafael.tinoco@linaro.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).