Re: [PATCH 26/50] tools/perf/build: Split out feature check: 'libbfd'

[David Ahern <dsahern@gmail.com>]

On 10/7/13 5:56 AM, Ingo Molnar wrote:
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 77a2e6b..4f60ecc 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -121,6 +121,7 @@ FEATURE_TESTS =				\
>   	libperl				\
>   	libpython			\
>   	libpython-version		\
> +	libbfd				\
>   	libnuma
>
>   $(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))

strlcpy missing from FEATURE_TESTS, but really the strlcpy changes 
should be a separate patch.

David

> @@ -423,7 +423,7 @@ else
>   endif
>
>   ifndef NO_STRLCPY
> -  ifeq ($(call try-cc,$(SOURCE_STRLCPY),,-DHAVE_STRLCPY_SUPPORT),y)
> +  ifeq ($(feature-strlcpy), 1)
>       CFLAGS += -DHAVE_STRLCPY_SUPPORT
>     endif
>   endif
> diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
> index d15074d..2a3473e 100644
> --- a/tools/perf/config/feature-checks/Makefile
> +++ b/tools/perf/config/feature-checks/Makefile
> @@ -19,6 +19,7 @@ FILES=					\
>   	test-libperl			\
>   	test-libpython			\
>   	test-libpython-version		\
> +	test-libbfd			\
>   	test-libnuma
>
>   CC := $(CC) -MD
> @@ -112,6 +113,12 @@ test-libpython:
>   test-libpython-version:
>   	$(BUILD) $(FLAGS_PYTHON_EMBED)
>
> +test-libbfd:
> +	$(BUILD) -DPACKAGE='perf' -DPACKAGE=perf -lbfd -ldl
> +
> +test-strlcpy:
> +	$(BUILD)
> +
>   -include *.d */*.d
>
>   ###############################
> diff --git a/tools/perf/config/feature-checks/test-libbfd.c b/tools/perf/config/feature-checks/test-libbfd.c
> new file mode 100644
> index 0000000..d03339c
> --- /dev/null
> +++ b/tools/perf/config/feature-checks/test-libbfd.c
> @@ -0,0 +1,7 @@
> +#include <bfd.h>
> +
> +int main(void)
> +{
> +	bfd_demangle(0, 0, 0);
> +	return 0;
> +}
> diff --git a/tools/perf/config/feature-checks/test-strlcpy.c b/tools/perf/config/feature-checks/test-strlcpy.c
> new file mode 100644
> index 0000000..4a6b6ff
> --- /dev/null
> +++ b/tools/perf/config/feature-checks/test-strlcpy.c
> @@ -0,0 +1,8 @@
> +#include <stdlib.h>
> +extern size_t strlcpy(char *dest, const char *src, size_t size);
> +
> +int main(void)
> +{
> +	strlcpy(NULL, NULL, 0);
> +	return 0;
> +}
>