From: Heiko Schocher <hs@denx.de>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, khali@linux-fr.org,
ben-linux@fluff.org, grant.likely@secretlab.ca, sjg@chromium.org,
naveenkrishna.ch@gmail.com, d.mueller@elsoft.ch, trini@ti.com,
mk7.kang@samsung.com, cpgs@samsung.com
Subject: Re: [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly
Date: Tue, 15 Oct 2013 08:06:09 +0200 [thread overview]
Message-ID: <525CDB51.70408@denx.de> (raw)
In-Reply-To: <1381813971-16006-1-git-send-email-ch.naveen@samsung.com>
Hello Naveen,
Am 15.10.2013 07:12, schrieb Naveen Krishna Chatradhi:
> The Exynos5 i2c driver does not handle NACKs properly. This change:
>
> - fixes the NACK processing problem (do not continue transaction if
> address cycle was NACKed)
>
> - eliminates a fair amount of duplicate code
>
> Signed-off-by: Vadim Bendebury<vbendeb@chromium.org>
> Reviewed-by: Simon Glass<sjg@google.com>
> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@samsung.com>
> ---
> Changes since v1:
> Fixed complilation warning in function i2c_init()
>
> Changes since v2:
> None
>
> drivers/i2c/s3c24x0_i2c.c | 214 +++++++++++++++++++--------------------------
> 1 file changed, 90 insertions(+), 124 deletions(-)
Hmm.. I think your patchset is for u-boot, or? But I could not find
the u-boot ml on cc... instead some linux ml ... if so, please resend
to the u-boot ml ...
(matches for all three patches from you)
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-10-15 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1380799354-14460-1-git-send-email-ch.naveen@samsung.com>
2013-10-15 5:12 ` [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly Naveen Krishna Chatradhi
2013-10-15 6:06 ` Heiko Schocher [this message]
2013-10-15 6:12 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525CDB51.70408@denx.de \
--to=hs@denx.de \
--cc=ben-linux@fluff.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=d.mueller@elsoft.ch \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mk7.kang@samsung.com \
--cc=naveenkrishna.ch@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).