From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796CAC4321E for ; Wed, 17 Nov 2021 11:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CA9E61181 for ; Wed, 17 Nov 2021 11:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236757AbhKQL1G (ORCPT ); Wed, 17 Nov 2021 06:27:06 -0500 Received: from mout.gmx.net ([212.227.15.18]:51891 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233972AbhKQL1E (ORCPT ); Wed, 17 Nov 2021 06:27:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637148180; bh=ggLkZ223a9rE1OZ+PtXEoMzttDhYwxytr42VAXoV0yE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=BrRmlP/GY5IAtD5RaALvtRW3ze40rofBypyrcN9z9QxIw8txqLRrgARH9jEXOqYwh KXJCBFDLvp+noaK8NG3dViHrGLXr9PXWBhDRREmClfx7gTSDyQRXtDGKChgyuXIeTh g1w/aYiaxLQznFcOTR3PWbtxZg5OKDTwRDI8qycI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.60] ([92.116.186.76]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mdeb5-1mEFOM2tNZ-00ZhYR; Wed, 17 Nov 2021 12:22:59 +0100 Message-ID: <525f9914-04bd-2d8a-0bbf-daf2d0d2053d@gmx.de> Date: Wed, 17 Nov 2021 12:22:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: Build regressions/improvements in v5.16-rc1 Content-Language: en-US To: Nick Terrell , Randy Dunlap Cc: Geert Uytterhoeven , Linux Kernel Mailing List , Rob Clark , "James E.J. Bottomley" , Anton Altaparmakov , Thomas Bogendoerfer , Sergio Paracuellos , Herbert Xu , Joey Gouly , Stan Skowronek , Hector Martin , Andrey Ryabinin , =?UTF-8?Q?Andr=c3=a9_Almeida?= , Peter Zijlstra , Linux ARM , "open list:GPIO SUBSYSTEM" , Parisc List , linux-arm-msm , DRI Development , "linux-ntfs-dev@lists.sourceforge.net" , linuxppc-dev , "open list:BROADCOM NVRAM DRIVER" , linux-pci , Linux Crypto Mailing List , kasan-dev References: <20211115155105.3797527-1-geert@linux-m68k.org> <480CE37B-FE60-44EE-B9D2-59A88FDFE809@fb.com> <78b2d093-e06c-ba04-9890-69f948bfb937@infradead.org> From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ecyVoIRPJxDu1rgYw3do9p97wWm9wU+AYBS1tvVaJ0qieCw2VM+ F4AcfYMJ6m/o5RfywfI4addVn5UKeIySukwDZx6nGaNJwYzhtTxzP+5Y9QaJhX+4OlwpAV1 nMwCfILf2+U0diPU2I9nlEi9f/czGOv/sIbvk3rRkJXeX3DOr1WSt6X93xYlDMTGlwHCyLR l+dXL+dPRpL0TjoJpT37A== X-UI-Out-Filterresults: notjunk:1;V03:K0:G/MV6HsODHM=:GxGTU642o4q5r5Bwlk703U vxYQ3KuDo6YpbOEcuglfWGzzkjMlrIx0ZlWv4JsMVqaIrnJ1r7AEdn0mG05l77wBkj9tPDp2p cxqkTdS0Rn8a3/aO+1h66Qc6kxo7zYE5k8wzhKYhg57qAdkipTcoDbYTRbCnwgd66capkEccM ninD/hUvLoeWSvRDoqj7mDSeesjpteCG2ikmPDhTRIHWTyXcduB6vwRQJADGEDklW8y85wAX2 8V74xNrEaQisjP8JC8Mjxt9pQ89HFPW5iIeFMhqGBusMX2Qc1A/dgqLsCecHDNVdOsLIZiVmd ZaVJy8Y4j1gCmWXjdIK4tPA2f2F7zz0I3Vr1J6DABpXhDXWjOi2t8Vc8FVWAkhlq0GDbOEa22 LvVPGyYOXK+zVo3NTpR2SRDD5inFdZofQgk3STxUADjWe0pADXhySizKoqI3hOiS+RCzugymz P013TEBW0pCuBuvtAqKPpPOVumpI1YuDb+ncGhnSEeZguPYfyEJiUT3LqBFxh2V2X/9WDi1OL qNNEwvJJpR2wgmPCQ/kQ3qSQwou+kAe5ZuGqjdVpjbC2+1SPL7YspRkKKCFCjlGLvlpcujvTj zxtITxo9yGX25rS+k4QKT7FDY+rDz9LFNYsvT3HSCPcBFodYcELgos1uLT9n1PzJIIFglJTNy cpq+8ki7uxvrFMqw7bsyXNJxR68GWOY013x2dDtJgKhUdBk4WQNZ/Me0K/gC1a3qgmWbxZVEH GtYiU9JkuGLmQpINKuY0akrnFChvA784RgR2Y+oWWX7bHsqEa0qmvePFVafGjVha3pfS3jDwL y23unIOpTU0uAViTehWJfapqMdY3tpQoYWYdv/SmH5afY7QhFeTXGQ8FRB1s2XKDJLBt9n3lx IDTZVBbDmPftiGHN4qbiC+2vCAg+1tRLbsC5sRU19gzI7dfG8Prt3dDPwiqfcixG4zTa7VAhA H7orwyCYt9MsOsiUyOjbPeaXA1amq+2kIKl82/FS6TVco9YcnlGYmRMIv09URP4HnnwNXA5hj sTan1CyZPpbhoC1X7yQVhT2hokL8Bo8TnOGfc+9A/n3r6zaF4fFADZRSvl/CYXmsCxwIXL3cV VuJSqXhAe0zLjg= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/21 03:19, Nick Terrell wrote: > > >> On Nov 16, 2021, at 6:05 PM, Randy Dunlap wrote= : >> >> On 11/16/21 5:59 PM, Nick Terrell wrote: >>>> On Nov 15, 2021, at 8:44 AM, Helge Deller wrote: >>>> >>>> On 11/15/21 17:12, Geert Uytterhoeven wrote: >>>>> On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven wrote: >>>>>> Below is the list of build error/warning regressions/improvements i= n >>>>>> v5.16-rc1[1] compared to v5.15[2]. >>>>>> >>>>>> Summarized: >>>>>> - build errors: +20/-13 >>>>>> - build warnings: +3/-28 >>>>>> >>>>>> Happy fixing! ;-) >>>>>> >>>>>> Thanks to the linux-next team for providing the build service. >>>>>> >>>>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcd= c43c1aa1ba12bca9d2dd4318c2a0dbf/ (all 90 configs) >>>>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca97= 2ad531c9b149c0a51ab43a417385813/ (all 90 configs) >>>>>> >>>>>> >>>>>> *** ERRORS *** >>>>>> >>>>>> 20 error regressions: >>>>>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expecte= d ':' before '__stringify': =3D> 33:4, 18:4 >>>>>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label '= l_yes' defined but not used [-Werror=3Dunused-label]: =3D> 38:1, 23:1 >>>>> >>>>> due to static_branch_likely() in crypto/api.c >>>>> >>>>> parisc-allmodconfig >>>> >>>> fixed now in the parisc for-next git tree. >>>> >>>> >>>>>> + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefin= ed [-Werror]: =3D> 531 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the fra= me size of 3252 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-th= an=3D]: =3D> 47:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the fra= me size of 3360 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-th= an=3D]: =3D> 499:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the fra= me size of 5344 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-th= an=3D]: =3D> 334:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the fra= me size of 5380 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-th= an=3D]: =3D> 354:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size= of 1824 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-than=3D]:= =3D> 372:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size= of 2224 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-than=3D]:= =3D> 204:1 >>>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size= of 3800 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-than=3D]:= =3D> 476:1 >>>>> >>>>> parisc-allmodconfig >>>> >>>> parisc needs much bigger frame sizes, so I'm not astonished here. >>>> During the v5.15 cycl I increased it to 1536 (from 1280), so I'm simp= ly tempted to >>>> increase it this time to 4096, unless someone has a better idea.... >>> This patch set should fix the zstd stack size warnings [0]. I=E2=80=99= ve >>> verified the fix using the same tooling: gcc-8-hppa-linux-gnu. >>> I=E2=80=99ll send the PR to Linus tomorrow. I=E2=80=99ve been informed= that it >>> isn't strictly necessary to send the patches to the mailing list >>> for bug fixes, but its already done, so I=E2=80=99ll wait and see if t= here >>> is any feedback. >> >> IMO several (or many more) people would disagree with that. >> >> "strictly?" OK, it's probably possible that almost any patch >> could be merged without being on a mailing list, but it's not >> desirable (except in the case of "security" patches). > > Good to know! Thanks for the advice, I wasn=E2=80=99t really sure what > the best practice is for sending patches to your own tree, as I > didn't see anything about it in the maintainer guide. Nick, thanks a lot for your efforts to get the frame size usage down! I've applied your patch series to the parisc for-next tree [1], so that it gets some testing in the upstream for-next tree. My tests so far are good, although I'm only using gcc-11. If you don't mind, and if it doesn't generate issues for other platforms & architectures I could submit them upstream to Linus when I send the next pull request. Helge [1] https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.gi= t/log/?h=3Dfor-next