linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V2 04/14] perf script: Set up output options for in-stream attributes
Date: Wed, 23 Oct 2013 07:15:21 +0100	[thread overview]
Message-ID: <52676979.7020909@gmail.com> (raw)
In-Reply-To: <1382427258-17495-5-git-send-email-adrian.hunter@intel.com>

On 10/22/13 8:34 AM, Adrian Hunter wrote:
> +static int process_attr(struct perf_tool *tool, union perf_event *event,
> +			struct perf_evlist **pevlist)
> +{
> +	struct perf_script *scr = container_of(tool, struct perf_script, tool);
> +	struct perf_evlist *evlist;
> +	struct perf_evsel *evsel, *pos;
> +	int err;
> +
> +	err = perf_event__process_attr(tool, event, pevlist);
> +	if (err)
> +		return err;
> +
> +	evlist = *pevlist;
> +	evsel = perf_evlist__last(*pevlist);

This assumes new entries are added to the end of evlist in 
perf_event__process_attr. Would be better to change it to return the 
newly created evsel so you don't need to look it up after adding it.

> +
> +	if (evsel->attr.type >= PERF_TYPE_MAX)
> +		return 0;
> +
> +	list_for_each_entry(pos, &evlist->entries, node) {
> +		if (pos->attr.type == evsel->attr.type && pos != evsel)
> +			return 0;
> +	}

What's the point of this loop?

David

  reply	other threads:[~2013-10-23  6:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22  7:34 [PATCH V2 00/14] perf tools: fixes and tweaks Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 01/14] perf tools: Fix non-debug build Adrian Hunter
2013-10-25 10:32   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 02/14] perf evsel: Add a debug print if perf_event_open fails Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 03/14] perf script: Make perf_script a local variable Adrian Hunter
2013-10-23  5:55   ` David Ahern
2013-10-25 10:32   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 04/14] perf script: Set up output options for in-stream attributes Adrian Hunter
2013-10-23  6:15   ` David Ahern [this message]
2013-10-23  6:41     ` Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 05/14] perf inject: Do not repipe attributes to a perf.data file Adrian Hunter
2013-10-25 10:32   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 06/14] perf tools: Fix 32-bit cross build Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 07/14] perf tools: Fix libunwind build and feature detection for 32-bit build Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 08/14] perf evlist: Add a debug print if event buffer mmap fails Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 09/14] perf record: Add an option to force per-cpu mmaps Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 10/14] perf tools: Allow non-matching sample types Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 11/14] perf sched: Make struct perf_sched sched a local variable Adrian Hunter
2013-10-23  6:43   ` David Ahern
2013-10-23 13:16     ` Arnaldo Carvalho de Melo
2013-10-25 10:32   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 12/14] perf sched: Fix optimized build time Adrian Hunter
2013-10-23  6:44   ` David Ahern
2013-10-23 13:17   ` Arnaldo Carvalho de Melo
2013-10-25 10:32   ` [tip:perf/core] perf sched: Optimize " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 13/14] perf tools: Do not accept parse_tag_value() overflow Adrian Hunter
2013-10-25 10:32   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22  7:34 ` [PATCH V2 14/14] perf tools: Validate that mmap_pages is not too big Adrian Hunter
2013-10-25 10:32   ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52676979.7020909@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).