From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chen Gang <gang.chen@asianux.com>,
alsa-devel@alsa-project.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
Date: Thu, 07 Nov 2013 08:54:46 +0100 [thread overview]
Message-ID: <527B4746.90009@ladisch.de> (raw)
In-Reply-To: <527B0595.5030108@asianux.com>
Chen Gang wrote:
> When installing, "scripts/headers_install.sh" will strip guard macro'
> "_UAPI" to prevent from appearing it to users. And also, all another
> files which need uapi prefix always use "_UAPI", not "UAPI".
>
> So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
> comment for "#endif".
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> include/uapi/sound/firewire.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/sound/firewire.h b/include/uapi/sound/firewire.h
> index e86131c..59f5961 100644
> --- a/include/uapi/sound/firewire.h
> +++ b/include/uapi/sound/firewire.h
> @@ -1,5 +1,5 @@
> -#ifndef UAPI_SOUND_FIREWIRE_H_INCLUDED
> -#define UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#ifndef _UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#define _UAPI_SOUND_FIREWIRE_H_INCLUDED
>
> #include <linux/ioctl.h>
>
> @@ -48,4 +48,4 @@ struct snd_firewire_get_info {
> * Returns -EBUSY if the driver is already streaming.
> */
>
> -#endif
> +#endif /* _UAPI_SOUND_FIREWIRE_H_INCLUDED */
next prev parent reply other threads:[~2013-11-07 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 3:14 [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI" Chen Gang
2013-11-07 7:54 ` Clemens Ladisch [this message]
2013-11-07 9:50 ` [alsa-devel] " Chen Gang
2013-11-07 9:29 ` Takashi Iwai
2013-11-07 9:49 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B4746.90009@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).