From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org
Subject: Re: [PATCH 1/2] clockevent: sun4i: Fill the irq field in the clockevent structure
Date: Thu, 07 Nov 2013 11:17:29 +0100 [thread overview]
Message-ID: <527B68B9.9060701@linaro.org> (raw)
In-Reply-To: <1382699771-4396-2-git-send-email-maxime.ripard@free-electrons.com>
On 10/25/2013 01:16 PM, Maxime Ripard wrote:
> The clock event structure irq field was not filled previously to the
> interrupt we're using.
>
> This was resulting in the timer not being used at all when using a
> configuration with SMP enabled on a system with several CPUs, and with
> the cpumask set to the cpu_possible_mask.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to my tree for 3.14
> ---
> drivers/clocksource/sun4i_timer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c
> index 2fb4695..a7f492e 100644
> --- a/drivers/clocksource/sun4i_timer.c
> +++ b/drivers/clocksource/sun4i_timer.c
> @@ -188,6 +188,7 @@ static void __init sun4i_timer_init(struct device_node *node)
> writel(val | TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_EN_REG);
>
> sun4i_clockevent.cpumask = cpumask_of(0);
> + sun4i_clockevent.irq = irq;
>
> clockevents_config_and_register(&sun4i_clockevent, rate,
> TIMER_SYNC_TICKS, 0xffffffff);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-11-07 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 11:16 [PATCH 0/2] More Allwinner SoC timer fixes Maxime Ripard
2013-10-25 11:16 ` [PATCH 1/2] clockevent: sun4i: Fill the irq field in the clockevent structure Maxime Ripard
2013-10-28 16:19 ` Stephen Boyd
2013-11-07 10:17 ` Daniel Lezcano [this message]
2013-10-25 11:16 ` [PATCH 2/2] clocksource: sun4i: change CPU mask to cpu_possible_mask Maxime Ripard
2013-10-28 16:19 ` Stephen Boyd
2013-11-07 10:19 ` Daniel Lezcano
2013-11-10 9:52 ` Maxime Ripard
2013-11-05 23:38 ` [PATCH 0/2] More Allwinner SoC timer fixes Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B68B9.9060701@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).