From: Rinat Gadelshin <rgadelsh@gmail.com>
To: Eiichi Tsukata <eiichi.tsukata@nutanix.com>,
paul@paul-moore.com, eparis@redhat.com,
linux-kernel@vger.kernel.org, audit@vger.kernel.org
Subject: Re: [PATCH 1/4] audit: refactor queue full checks
Date: Wed, 10 May 2023 09:54:39 +0300 [thread overview]
Message-ID: <527bf278-48a3-1b43-a23f-dd4cbb92ef19@gmail.com> (raw)
In-Reply-To: <20230508075812.76077-2-eiichi.tsukata@nutanix.com>
Hi Eiichi!
Just one one for your patch.
On 08.05.2023 10:58, Eiichi Tsukata wrote:
> Currently audit queue full checks are done in multiple places.
> Consolidate them into one audit_queue_full().
>
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
> ---
> kernel/audit.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 9bc0b0301198..c15694e1a76b 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -341,6 +341,12 @@ static inline int audit_rate_check(void)
> return retval;
> }
>
> +static inline int audit_queue_full(const struct sk_buff_head *queue)
> +{
> + return audit_backlog_limit &&
> + (skb_queue_len(queue) > audit_backlog_limit);
It seems that we should use `>=` here.
> +}
> +
> /**
> * audit_log_lost - conditionally log lost audit message event
> * @message: the message stating reason for lost audit message
> @@ -579,8 +585,7 @@ static void kauditd_hold_skb(struct sk_buff *skb, int error)
> * record on the retry queue unless it's full, in which case drop it
> */
> if (error == -EAGAIN) {
> - if (!audit_backlog_limit ||
> - skb_queue_len(&audit_retry_queue) < audit_backlog_limit) {
> + if (!audit_queue_full(&audit_retry_queue)) {
> skb_queue_tail(&audit_retry_queue, skb);
> return;
> }
> @@ -589,8 +594,7 @@ static void kauditd_hold_skb(struct sk_buff *skb, int error)
> }
>
> /* if we have room in the hold queue, queue the message */
> - if (!audit_backlog_limit ||
> - skb_queue_len(&audit_hold_queue) < audit_backlog_limit) {
> + if (!audit_queue_full(&audit_hold_queue)) {
> skb_queue_tail(&audit_hold_queue, skb);
> return;
> }
> @@ -613,8 +617,7 @@ static void kauditd_hold_skb(struct sk_buff *skb, int error)
> */
> static void kauditd_retry_skb(struct sk_buff *skb, __always_unused int error)
> {
> - if (!audit_backlog_limit ||
> - skb_queue_len(&audit_retry_queue) < audit_backlog_limit) {
> + if (!audit_queue_full(&audit_retry_queue)) {
> skb_queue_tail(&audit_retry_queue, skb);
> return;
> }
> @@ -1564,8 +1567,7 @@ static void audit_receive(struct sk_buff *skb)
> audit_ctl_unlock();
>
> /* can't block with the ctrl lock, so penalize the sender now */
> - if (audit_backlog_limit &&
> - (skb_queue_len(&audit_queue) > audit_backlog_limit)) {
> + if (audit_queue_full(&audit_queue)) {
> DECLARE_WAITQUEUE(wait, current);
>
> /* wake kauditd to try and flush the queue */
> @@ -1866,8 +1868,7 @@ struct audit_buffer *audit_log_start(struct audit_context *ctx, gfp_t gfp_mask,
> if (!(auditd_test_task(current) || audit_ctl_owner_current())) {
> long stime = audit_backlog_wait_time;
>
> - while (audit_backlog_limit &&
> - (skb_queue_len(&audit_queue) > audit_backlog_limit)) {
> + while (audit_queue_full(&audit_queue)) {
> /* wake kauditd to try and flush the queue */
> wake_up_interruptible(&kauditd_wait);
>
next prev parent reply other threads:[~2023-05-10 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 7:58 [PATCH 0/4] audit: refactor and fix for potential deadlock Eiichi Tsukata
2023-05-08 7:58 ` [PATCH 1/4] audit: refactor queue full checks Eiichi Tsukata
2023-05-10 6:54 ` Rinat Gadelshin [this message]
2023-05-10 7:17 ` Eiichi Tsukata
2023-05-10 7:28 ` Rinat Gadelshin
2023-05-08 7:58 ` [PATCH 2/4] audit: account backlog waiting time in audit_receive() Eiichi Tsukata
2023-05-08 7:58 ` [PATCH 3/4] audit: convert DECLARE_WAITQUEUE to DEFINE_WAIT Eiichi Tsukata
2023-05-08 7:58 ` [PATCH 4/4] audit: check if queue is full after prepare_to_wait_exclusive() Eiichi Tsukata
2023-05-08 17:13 ` kernel test robot
2023-05-09 1:44 ` Eiichi Tsukata
2023-05-08 14:07 ` [PATCH 0/4] audit: refactor and fix for potential deadlock Paul Moore
2023-05-09 1:34 ` Eiichi Tsukata
2023-05-10 8:09 ` Eiichi Tsukata
2023-05-17 16:15 ` Paul Moore
2023-05-17 16:03 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527bf278-48a3-1b43-a23f-dd4cbb92ef19@gmail.com \
--to=rgadelsh@gmail.com \
--cc=audit@vger.kernel.org \
--cc=eiichi.tsukata@nutanix.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).