From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907Ab3KVTN4 (ORCPT ); Fri, 22 Nov 2013 14:13:56 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:56312 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755334Ab3KVTNz (ORCPT ); Fri, 22 Nov 2013 14:13:55 -0500 Message-ID: <528FACF0.5090604@gmail.com> Date: Fri, 22 Nov 2013 12:13:52 -0700 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Frederic Weisbecker , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded References: <1384806771-2945-1-git-send-email-dsahern@gmail.com> <1384806771-2945-4-git-send-email-dsahern@gmail.com> <20131122184458.GE11305@ghostprotocols.net> In-Reply-To: <20131122184458.GE11305@ghostprotocols.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu: >> Save vmlinux or kallsyms path loaded using embedded default lookup (ie., >> not a user specified path). Upcoming perf sched timehist command requires >> kernel symbols for properly computing idle times and prints a warning >> if the kernel symbols are not loaded. > > What would happen if strdup failed here? perf continues on happily. On the timehist command will question computation of idle times which require kernel symbols. > > Why don't we undo anything done so far in this function and return an > error? > In the notion of best effort of continuing. It's not a show stopper that strdup failed; it's just not the filename it used for symbols. David