From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Rob Herring <rob.herring@calxeda.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Brown <davidb@codeaurora.org>
Subject: Re: [PATCH] clocksource: Do not drop unheld reference on device node
Date: Mon, 25 Nov 2013 09:57:39 +0100 [thread overview]
Message-ID: <52931103.7030107@linaro.org> (raw)
In-Reply-To: <20131125072923.GB28642@pengutronix.de>
On 11/25/2013 08:29 AM, Uwe Kleine-König wrote:
> Hello Daniel,
>
> On Sun, Nov 24, 2013 at 10:28:15PM +0100, Daniel Lezcano wrote:
>> On 11/22/2013 08:22 PM, Uwe Kleine-König wrote:
>>> On Fri, Nov 22, 2013 at 05:31:46PM +0100, Daniel Lezcano wrote:
>>>> On 11/22/2013 05:16 PM, Thierry Reding wrote:
>>>>> On Sat, Oct 19, 2013 at 12:49:48AM +0200, Thierry Reding wrote:
>>>> Yes. Sounds like I missed it.
>>>>
>>>> This regression has been introduced by:
>>>>
>>>> commit 326e31eebe61dc838e031ea16968b2cfb43443e3
>>>> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>> Date: Tue Oct 1 11:00:53 2013 +0200
>>>>
>>>> clocksource: Put nodes passed to CLOCKSOURCE_OF_DECLARE
>>>> callbacks centrally
>>>>
>>>> Instead of letting each driver call of_node_put do it centrally in the
>>>> loop that also calls the CLOCKSOURCE_OF_DECLARE callbacks. This is less
>>>> prone to error and also moves getting and putting the references
>>>> into the
>>>> same function.
>>>>
>>>> Consequently all respective of_node_put calls in drivers are removed.
>>>>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>> Acked-by: David Brown <davidb@codeaurora.org>
>>> Still all but the hook in clocksource_of_init of this commit was
>>> correct, right? (Well, but this buggy hunk makes the commit log wrong.)
>>
>> I don't understand your comment, can you elaborate ?
> My patch added an of_node_put in clocksource_of_init and dropped several
> of_node_puts in drivers. This thread is about the first being wrong. My
> question was if dropping the others was correct.
Yes, Thierry's patch removes the of_node_puts but I am also wondering if
we shouldn't just revert the patch 326e31eebe61dc838e instead.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-11-25 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 22:49 [PATCH] clocksource: Do not drop unheld reference on device node Thierry Reding
2013-11-22 16:16 ` Thierry Reding
2013-11-22 16:31 ` Daniel Lezcano
2013-11-22 19:22 ` Uwe Kleine-König
2013-11-24 21:28 ` Daniel Lezcano
2013-11-25 7:29 ` Uwe Kleine-König
2013-11-25 8:57 ` Daniel Lezcano [this message]
2013-11-25 9:04 ` Thierry Reding
2013-11-25 8:59 ` Thierry Reding
2013-11-28 8:23 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52931103.7030107@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).