From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122Ab3K1BqD (ORCPT ); Wed, 27 Nov 2013 20:46:03 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34509 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338Ab3K1BqA (ORCPT ); Wed, 27 Nov 2013 20:46:00 -0500 Message-ID: <5296A0CF.2020405@gmail.com> Date: Thu, 28 Nov 2013 09:47:59 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Dan Carpenter CC: Greg KH , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , rkuo , hans.verkuil@cisco.com, Joe Perches , linux-media@vger.kernel.org, m.chehab@samsung.com Subject: Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() References: <20131125011938.GB18921@codeaurora.org> <5292B845.3010404@gmail.com> <5292B8A0.7020409@gmail.com> <5294255E.7040105@gmail.com> <52956442.50001@gmail.com> <1385522475.18487.34.camel@joe-AO722> <529569A5.1020008@gmail.com> <52956B78.6050107@gmail.com> <20131127040338.GB23930@kroah.com> <529573F6.9080106@gmail.com> <20131127104325.GE28413@mwanda> In-Reply-To: <20131127104325.GE28413@mwanda> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/2013 06:43 PM, Dan Carpenter wrote: > On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: >> On 11/27/2013 12:03 PM, Greg KH wrote: >>> On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >>>> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >>>> of before 'go' initialized. Related warning (with allmodconfig under >>>> hexagon): >>>> >>>> CC [M] drivers/staging/media/go7007/go7007-usb.o >>>> drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': >>>> drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] >>>> >>>> Also remove useless code after 'return' statement. >>> >>> This should all be fixed in my staging-linus branch already, right? No >>> need for this anymore from what I can tell, sorry. >>> >> >> That's all right (in fact don't need sorry). :-) >> >> And excuse me, I am not quite familiar upstream kernel version merging >> and branches. Is it still better/suitable/possible to sync some bug fix >> patches from staging brach to next brach? > > next syncs with everyone once a day. > OK, thanks. :-) -- Chen Gang