From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, dsahern@gmail.com,
adrian.hunter@intel.com, jolsa@redhat.com, namhyung@kernel.org,
acme@ghostprotocols.net, mingo@redhat.com,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH] perf target: Move what map fucntion to call check into function.
Date: Thu, 28 Nov 2013 16:54:56 -0500 [thread overview]
Message-ID: <5297BBB0.8030104@cn.fujitsu.com> (raw)
In-Reply-To: <1385667174-16181-1-git-send-email-yangds.fnst@cn.fujitsu.com>
I will resend the correct one. Sorry for the bother.
On 11/28/2013 02:32 PM, Dongsheng Yang wrote:
> Check for cpu_map__dummy_new() or cpu_map__new() to be called in
> perf_evlist__create_maps() is more complicated. This patch moves
> the checking work into target.h, combining two conditions and making
> perf_evlist__create_maps() more readable.
>
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> tools/perf/util/evlist.c | 8 +-------
> tools/perf/util/target.h | 13 +++++++++++++
> 2 files changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 76fa764..7bb6ee1 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -819,13 +819,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target)
> if (evlist->threads == NULL)
> return -1;
>
> - if (target->default_per_cpu)
> - evlist->cpus = target->per_thread ?
> - cpu_map__dummy_new() :
> - cpu_map__new(target->cpu_list);
> - else if (target__has_task(target))
> - evlist->cpus = cpu_map__dummy_new();
> - else if (!target__has_cpu(target) && !target->uses_mmap)
> + if (target__uses_dummy_map(target))
> evlist->cpus = cpu_map__dummy_new();
> else
> evlist->cpus = cpu_map__new(target->cpu_list);
> diff --git a/tools/perf/util/target.h b/tools/perf/util/target.h
> index 31dd2e9..7381b1c 100644
> --- a/tools/perf/util/target.h
> +++ b/tools/perf/util/target.h
> @@ -63,4 +63,17 @@ static inline bool target__none(struct target *target)
> return !target__has_task(target) && !target__has_cpu(target);
> }
>
> +static inline bool target__uses_dummy_map(struct target *target)
> +{
> + bool use_dummy = false;
> +
> + if (target->default_per_cpu)
> + use_dummy = target->per_thread ? true : false;
> + else if (target__has_task(target) ||
> + (!target__has_cpu(target) && !target->uses_mmap))
> + use_dummy = true;
> +
> + return use_dummy;
> +}
> +
> #endif /* _PERF_TARGET_H */
prev parent reply other threads:[~2013-11-28 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 19:32 [PATCH] perf target: Move what map fucntion to call check into function Dongsheng Yang
2013-11-28 21:54 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5297BBB0.8030104@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).