From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762059AbdACXe7 convert rfc822-to-8bit (ORCPT ); Tue, 3 Jan 2017 18:34:59 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55453 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762008AbdACXeO (ORCPT ); Tue, 3 Jan 2017 18:34:14 -0500 content-type: text/plain; charset="utf-8" in-reply-to: <20170103225127.jn36tatufdfz2k5q@rob-hp-laptop> from: "Peter Senna Tschudin" X-Forward: 82.136.76.99 date: Tue, 03 Jan 2017 23:34:04 +0000 cc: jslaby@suse.cz, dri-devel@lists.freedesktop.org, martyn.welch@collabora.co.uk, tiwai@suse.com, linux@armlinux.org.uk, galak@codeaurora.org, peter.senna@gmail.com, architt@codeaurora.org, "Fabio Estevam" , ijc+devicetree@hellion.org.uk, davem@davemloft.net, mark.rutland@arm.com, rmk+kernel@armlinux.org.uk, kernel@pengutronix.de, enric.balletbo@collabora.com, mchehab@osg.samsung.com, "Peter Senna Tschudin" , treding@nvidia.com, gregkh@linuxfoundation.org, p.zabel@pengutronix.de, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, javier@dowhile0.org, devicetree@vger.kernel.org, martin.donnelly@ge.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, eballetbo@gmail.com, pawel.moll@arm.com, airlied@linux.ie, ykk@rock-chips.com, heiko@sntech.de, thierry.reding@gmail.com, daniel.vetter@ffwll.ch, linux@roeck-us.net to: "Rob Herring" MIME-Version: 1.0 message-id: <529b-586c3500-5-5e05b080@98620974> subject: =?utf-8?q?Re=3A?==?utf-8?q?_=5BPATCH?= V7 =?utf-8?q?1=2F4=5D?= =?utf-8?q?_Documentation=2Fdevicetree=2Fbindings=3A?= =?utf-8?q?_b850v3=5Flvds=5Fdp?= User-Agent: SOGoMail 2.3.11 content-transfer-encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the review. On 03 January, 2017 23:51 CET, Rob Herring wrote: > On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote: > > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > > display bridge. > > > > Cc: Martyn Welch > > Cc: Martin Donnelly > > Cc: Javier Martinez Canillas > > Cc: Enric Balletbo i Serra > > Cc: Philipp Zabel > > Cc: Rob Herring > > Cc: Fabio Estevam > > Signed-off-by: Peter Senna Tschudin > > --- > > There was an Acked-by from Rob Herring for V6, but I changed > > the bindings to use i2c_new_secondary_device() so I removed it from the commit > > message. > > > > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++ > > Generally, bindings are not organized by vendor. Put in > bindings/display/bridge/... instead. Will change that. > > > 1 file changed, 39 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > > > > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > > new file mode 100644 > > index 0000000..1bc6ebf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt > > @@ -0,0 +1,39 @@ > > +Driver for GE B850v3 LVDS/DP++ display bridge > > + > > +Required properties: > > + - compatible : should be "ge,b850v3-lvds-dp". > > Isn't '-lvds-dp' redundant? The part# should be enough. b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output? > > > + - reg : should contain the main address which is used to ack the > > + interrupts and address for edid. > > + - reg-names : comma separeted list of register names. Valid values > > s/separeted/separated/ argh, sorry for this. Will fix it. > > > + are "main", and "edid". > > + - interrupt-parent : phandle of the interrupt controller that services > > + interrupts to the device > > + - interrupts : one interrupt should be described here, as in > > + <0 IRQ_TYPE_LEVEL_HIGH>. > > + - port : should describe the video signal connection between the host > > + and the bridge. > > + > > +Example: > > + > > +&mux2_i2c2 { > > + status = "okay"; > > + clock-frequency = <100000>; > > + > > + b850v3-lvds-dp-bridge@73 { > > + compatible = "ge,b850v3-lvds-dp"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + reg = <0x73 0x72>; > > + reg-names = "main", "edid"; > > + > > + interrupt-parent = <&gpio2>; > > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > + > > + port { > > + b850v3_dp_bridge_in: endpoint { > > + remote-endpoint = <&lvds0_out>; > > + }; > > + }; > > + }; > > +}; > > -- > > 2.5.5 > >